From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480AbbJSGCc (ORCPT ); Mon, 19 Oct 2015 02:02:32 -0400 Received: from down.free-electrons.com ([37.187.137.238]:39042 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751209AbbJSGCa (ORCPT ); Mon, 19 Oct 2015 02:02:30 -0400 Date: Mon, 19 Oct 2015 08:02:26 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Samuel Ortiz , Lee Jones , Liam Girdwood , Mark Brown , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Hans de Goede , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Subject: Re: [linux-sunxi] Re: [PATCH 3/6] mfd: axp20x: Add support for RSB based AXP223 PMIC Message-ID: <20151019060226.GQ2711@lukather> References: <1444840342-9233-1-git-send-email-wens@csie.org> <1444840342-9233-4-git-send-email-wens@csie.org> <20151016064159.GG2711@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eBTWNsZZiigckDWV" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eBTWNsZZiigckDWV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 16, 2015 at 02:46:23PM +0800, Chen-Yu Tsai wrote: > On Fri, Oct 16, 2015 at 2:41 PM, Maxime Ripard > wrote: > > On Thu, Oct 15, 2015 at 12:32:19AM +0800, Chen-Yu Tsai wrote: > >> The AXP223 is a new PMIC commonly paired with Allwinner A23/A33 SoCs. > >> It is functionally identical to AXP221; only the regulator default > >> voltage/status and the external host interface are different. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> drivers/mfd/Kconfig | 12 ++++++ > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/axp20x-core.c | 2 + > >> drivers/mfd/axp20x-rsb.c | 93 +++++++++++++++++++++++++++++++++++++= +++++++++ > >> include/linux/mfd/axp20x.h | 1 + > >> 5 files changed, 109 insertions(+) > >> create mode 100644 drivers/mfd/axp20x-rsb.c > >> > >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > >> index 9ba3feb3f2fc..6e5edb61d42e 100644 > >> --- a/drivers/mfd/Kconfig > >> +++ b/drivers/mfd/Kconfig > >> @@ -84,6 +84,7 @@ config MFD_BCM590XX > >> config MFD_AXP20X > >> bool "X-Powers AXP series PMICs" > >> select MFD_AXP20X_I2C > >> + select MFD_AXP20X_RSB > >> > >> config MFD_AXP20X_CORE > >> bool > >> @@ -102,6 +103,17 @@ config MFD_AXP20X_I2C > >> components like regulators or the PEK (Power Enable Key) under= the > >> corresponding menus. > >> > >> +config MFD_AXP20X_RSB > >> + bool "X-Powers AXP series RSB PMICs" > >> + select MFD_AXP20X_CORE > >> + depends on SUNXI_RSB=3Dy > > > > Do we need that? Even if the bus is compiled as a module, the driver > > will not be probed before that, will it? >=20 > There's a compile/link dependency on the __devm_regmap_init_sunxi_rsb(). If it's exported, everything should be fine, no? > And both drivers are bool, i.e. can't be compiled as a module. What we > don't want is enabling MFD_AXP20X_RSB without SUNXI_RSB. What would really be the issue here? The driver wouldn't be probed, and that's it. Or am I missing something? Maxime > AFAIK the same goes for the I2C version. --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --eBTWNsZZiigckDWV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWJIdyAAoJEBx+YmzsjxAgx+UQAKdsp7tgU5DhRwTXF5RPabtP e0B6ZA37WVhUK1t4J1lQ6ESqHLRbjltuBITsJBG6f2t+N+crkRn8K5bc8hJpt4Fg BxrzT4Zq035IXdzzpBw+u/oX6uopI2DDAhqZZskYWOCC4w0rC3TpbA6gH9LpLtvX xIf7HNiHKPNTCSb6sADwBhft0k7e0DrEtTCC+hVuXSPVkaOOyi+A+SPz0wiesHZ7 5hDkbB++M7J7iUZWMNK1xcGdg2ulZMnKK3SkvNaNxudLqrrEWmnL9BNGe6bB66a8 Tti1AbRSRsvqisbAvDZAUX5wDpl86ddQU8zplM1Dyw1M4V3uJkzBC41qJO9pUKlA UDo7shCiDx1sIIxo7bf++65N0O3kAaZmzd9XQovmvOUGSoikIIwqjigx5zrM9H83 v5mCe75tipzPtPikbAwUSPWXrQ+UDDWmB7pXVnOq9cSdWPtWacYkAVhWz3yjT+ug i7S2y/lWcqKxJ5itAk2KFSbeyTuC+F3jrLAHn5s6NZSoAVm4FB71JfJ82vLMhwgy ETIi4TwWzci1dJJ+nbiy2tAuoX5Ug1mFtJ7kjhS9n6bx9COijKC4iRHsRq4vcpeX yOLduPDu8DpzMZmAgKRimqAyS8dRhkQCSZ8EMfsGRFSq8/6AFCy50QE1MebXAdQD Yift4ledO8OWpZyP0FSG =H0tn -----END PGP SIGNATURE----- --eBTWNsZZiigckDWV--