From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbbJSJNT (ORCPT ); Mon, 19 Oct 2015 05:13:19 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:35771 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753372AbbJSJNR (ORCPT ); Mon, 19 Oct 2015 05:13:17 -0400 Date: Mon, 19 Oct 2015 10:13:11 +0100 From: Lee Jones To: "Andrew F. Davis" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mark Brown , Alexandre Courbot , Grygorii Strashko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] Documentation: tps65086: Add DT bindings for the TPS65086 PMIC Message-ID: <20151019091311.GH31804@x1> References: <1445014753-15450-1-git-send-email-afd@ti.com> <1445014753-15450-2-git-send-email-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1445014753-15450-2-git-send-email-afd@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Oct 2015, Andrew F. Davis wrote: > The TPS65086 PMIC contains several regulators and a GPO controller. > Add bindings for the TPS65086 PMIC. > > Signed-off-by: Andrew F. Davis > --- > .../devicetree/bindings/gpio/gpio-tps65086.txt | 17 ++++++++ > Documentation/devicetree/bindings/mfd/tps65086.txt | 46 ++++++++++++++++++++++ > .../bindings/regulator/tps65086-regulator.txt | 36 +++++++++++++++++ Please split these up into separate patches. There is no functional reason to bundle them up. > 3 files changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-tps65086.txt > create mode 100644 Documentation/devicetree/bindings/mfd/tps65086.txt > create mode 100644 Documentation/devicetree/bindings/regulator/tps65086-regulator.txt [...] > diff --git a/Documentation/devicetree/bindings/mfd/tps65086.txt b/Documentation/devicetree/bindings/mfd/tps65086.txt > new file mode 100644 > index 0000000..4b6aeb4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/tps65086.txt > @@ -0,0 +1,46 @@ > +* TPS65086 Power Management Integrated Circuit bindings > + > +Required properties: > + - compatible : Should be "ti,tps65086". Any indication that it's a PMIC? > + - reg : Slave address. I2C/SPI? > + - interrupt-parent : The parent interrupt controller. Phandled to ... > + - interrupts : The interrupt line the device is connected to. > + - interrupt-controller : Marks the device node as an interrupt controller. > + - #interrupt-cells : The number of cells to describe an IRQ, this > + should be 2. The first cell is the IRQ number. > + The second cell is the flags, encoded as the trigger > + masks from ../interrupt-controller/interrupts.txt. Masks? What masks? Best to make a link to the header where the flags are defined here. > +Additional nodes defined in: > + - Regulators : ../regulator/tps65086-regulator.txt. > + - GPIO : ../gpio/gpio-tps65086.txt. I'd suggest removing the full stops from all of the lines above. Just treat them as bullet points like we normally do. > +Example: > + > + pmic: tps65086@5e { > + compatible = "ti,tps65086"; > + reg = <0x5e>; > + interrupt-parent = <&gpio1>; > + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + regulators { > + compatible = "ti,tps65086-regulator"; > + > + buck1 { > + regulator-name = "vcc1"; > + regulator-min-microvolt = <1600000>; > + regulator-max-microvolt = <1600000>; > + regulator-boot-on; > + ti,regulator-decay; > + ti,regulator-step-size-25mv; > + }; > + }; > + > + gpio4: tps65086_gpio { > + compatible = "ti,tps65086-gpio"; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + }; [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog