From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbbJSOsy (ORCPT ); Mon, 19 Oct 2015 10:48:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38418 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbbJSOsv (ORCPT ); Mon, 19 Oct 2015 10:48:51 -0400 Date: Mon, 19 Oct 2015 16:48:47 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, stable@vger.kernel.org, Yang Z Zhang Subject: Re: [PATCH v2] kvm: x86: zero EFER on INIT Message-ID: <20151019144846.GA3396@potion.brq.redhat.com> References: <1445247301-5150-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1445247301-5150-1-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-10-19 11:35+0200, Paolo Bonzini: > Not zeroing EFER means that a 32-bit firmware cannot enter paging mode > without clearing EFER.LME first (which it should not know about). > Yang Zhang from Intel confirmed that the manual is wrong and EFER is > cleared to zero on INIT. Also in APM v2, "Table 14-1. Initial Processor State.". > > Fixes: d28bc9dd25ce023270d2e039e7c98d38ecbf7758 > Cc: stable@vger.kernel.org > Cc: Yang Z Zhang > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Radim Krčmář