From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753677AbbJSOxS (ORCPT ); Mon, 19 Oct 2015 10:53:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43986 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbJSOxQ (ORCPT ); Mon, 19 Oct 2015 10:53:16 -0400 Date: Mon, 19 Oct 2015 12:53:12 -0200 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Wang Nan , acme@kernel.org, ast@plumgrid.com, brendan.d.gregg@gmail.com, a.p.zijlstra@chello.nl, daniel@iogearbox.net, dsahern@gmail.com, hekuang@huawei.com, jolsa@kernel.org, lizefan@huawei.com, masami.hiramatsu.pt@hitachi.com, paulus@samba.org, linux-kernel@vger.kernel.org, pi3orama@163.com, xiakaixu@huawei.com Subject: Re: [PATCH 21/31] perf test: Enforce LLVM test, add kbuild test Message-ID: <20151019145312.GA2359@redhat.com> References: <1444826502-49291-1-git-send-email-wangnan0@huawei.com> <1444826502-49291-22-git-send-email-wangnan0@huawei.com> <20151019144231.GA14297@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151019144231.GA14297@danjae.kornet> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Oct 19, 2015 at 11:42:31PM +0900, Namhyung Kim escreveu: > Hi, > > On Wed, Oct 14, 2015 at 12:41:32PM +0000, Wang Nan wrote: > > This patch enforces existing LLVM test, makes it compile more than one > > BPF source file. The compiled results are stored, can be used for other > > testcases. Except the first testcase (named LLVM_TESTCASE_BASE), failures > > of other test cases are not considered as failure of the whole test. > > > > Adds a kbuild testcase to check whether kernel headers can be correctly > > found. > > > > For example: > > > > # perf test LLVM > > > > 38: Test LLVM searching and compiling : (llvm.kbuild-dir can be fixed) Ok > > IMHO it'd be better to keep the test result simply as either "Ok" or > "FAILED" and provide details with -v option. "Skipped" looks more natural here, with the reason for it skipping being shown only with -v. Ingo made some comments about 'perf test' output recently, have you read that? > Anyway I found the tracepoint error message is annoying in the current You mean all these warnings: [root@zoo ~]# perf test "parse event" 5: parse events tests : Warning: [sunrpc:xprt_lookup_rqst] function __builtin_constant_p not defined Warning: [sunrpc:xprt_transmit] function __builtin_constant_p not defined Warning: [sunrpc:xprt_complete_rqst] function __builtin_constant_p not defined Warning: [xen:xen_mmu_set_pud] function sizeof not defined Warning: [xen:xen_mmu_set_pgd] function sizeof not defined Warning: [xen:xen_mmu_ptep_modify_prot_start] function sizeof not defined Warning: [xen:xen_mmu_ptep_modify_prot_commit] function sizeof not defined Ok [root@zoo ~]# i.e. making those warnings appear only under 'perf test -v'? Cool! > perf test output. Will send a fix soon. > > Thanks, > Namhyung