From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932159AbbJSS4M (ORCPT ); Mon, 19 Oct 2015 14:56:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36009 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbbJSS4K (ORCPT ); Mon, 19 Oct 2015 14:56:10 -0400 Date: Mon, 19 Oct 2015 16:56:07 -0200 From: Arnaldo Carvalho de Melo To: David Ahern Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Peter Zijlstra , Namhyung Kim , Jiri Olsa , Hitoshi Mitake , Linus Torvalds , Thomas Gleixner Subject: Re: [PATCH 08/14] perf/bench/mem: Rename 'routine' to 'routine_str' Message-ID: <20151019185607.GG2359@redhat.com> References: <1445241870-24854-1-git-send-email-mingo@kernel.org> <1445241870-24854-9-git-send-email-mingo@kernel.org> <5624F176.5040801@gmail.com> <20151019185447.GF2359@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151019185447.GF2359@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Oct 19, 2015 at 04:54:47PM -0200, Arnaldo Carvalho de Melo escreveu: > Em Mon, Oct 19, 2015 at 07:34:46AM -0600, David Ahern escreveu: > > On 10/19/15 2:04 AM, Ingo Molnar wrote: > > >@@ -128,7 +128,7 @@ static void __bench_mem_routine(struct bench_mem_info *info, int r_idx, size_t l > > > double result_bps = 0.0; > > > u64 result_cycles = 0; > > > > > >- printf("Routine %s (%s)\n", r->name, r->desc); > > >+ printf("routine %s (%s)\n", r->name, r->desc); > > > > > > if (bench_format == BENCH_FORMAT_DEFAULT) > > > printf("# Copying %s Bytes ...\n\n", length_str); > > > > Seems like 'R' is more appropriate here. > > Right, changed it. And then, he does that on a later patch, duh. - Arnaldo