From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbbJTGCU (ORCPT ); Tue, 20 Oct 2015 02:02:20 -0400 Received: from mail-by2on0131.outbound.protection.outlook.com ([207.46.100.131]:53371 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750787AbbJTGCS (ORCPT ); Tue, 20 Oct 2015 02:02:18 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Tue, 20 Oct 2015 14:01:08 +0800 From: Peter Chen To: Jiada Wang CC: , , Subject: Re: [PATCH] usb: chipidea: udc: clear vbus_active flag in udc_stop Message-ID: <20151020060107.GA27364@shlinux2> References: <1445308158-23100-1-git-send-email-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1445308158-23100-1-git-send-email-jiada_wang@mentor.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD011;1:MjLJYDojsYaSG8k78RqoHTcHCF/t3W7+YyFLrW6ZnP4ohvqsSfWO0eHmWGaG57py+7AKdCofdiNfNLkminzdyp+GW0XPaWtV7Z7JqeTXctOUP2zHp9qvjsTs/Trz+oruuuK1ydBEal/Hx1pltzvYpVK5GU8qmzLxAyp65QZOpA0yTHZNS1+eFAUmKA+xn6ZeSh5xT/4hHhrORrGngXJDAHmIFVgIZpWNyIDlVARZQxPe86T24Cv/IefM1pbpiwXQ9lk1o2VW1Tm87fdpcDkb0viVN2upM4env6oHT5F+MuxbvpzuMJ6BFC2EQeqp69vEiyK44Tt9oOO0FfiJlBe57einf/BH6pgbl6nsvf1UwxnrNPWwcA8LimQotRTprL0q X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(189002)(5008740100001)(2950100001)(92566002)(33716001)(50466002)(11100500001)(85426001)(86362001)(97736004)(87936001)(76176999)(81156007)(54356999)(83506001)(46406003)(4001350100001)(6806005)(105606002)(104016004)(106466001)(19580405001)(5001960100002)(19580395003)(110136002)(23726002)(64706001)(77096005)(5007970100001)(46102003)(33656002)(97756001)(47776003)(189998001)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB1276;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1276;2:mWWUXp4EpS7YdAtgzYK+vPDLZqD3LnJ/30d11dSrqGiRL9qDCWK7Vs7ddFFUR6HVM+/WW7d+Qunq9lZGoRZNIA2+l6CI0DWWdDFRPNlb0fbiRvmmflcG03v5qjKOnP6lw2VWHo8BZJ+ZppOhlcN8PDDRIf3FHNA3QmC3ygEa4ZA=;3:2PlKXuzLdQWgRVOxcfuGeVPRr5A/buR23w/NskEpfdTVnuV/f3OdvjvY8nUts+/aErrjpE0U0gFw1Hr1c/+qfnbhWdR6kXzP98MWDTK/ykLGY60UmapW1WTwUGKkvqHnZSuYdwx1XpHYQAVQP9dobzvfe7HoxWFNMAqo41K9FSle5Swkgkp8MrubPk4uudVduKMkH0zezbH0QfmrtK5iip5uP4MbQLlau40IuXTY1Jk=;25:SjDeM7Wglz4ODzHPb01DRrvKQ3es5BtpITrpB95WGJvN2dq07qGsj1roxQpUKnVMlizuOK48w6VWJY1TWA5Jb5JunsI6e4W4EooGkngqgwfB2ex3/SvF+mfKmzvmrHce5OaTqopRxFBN7f4PnvwMY4rivmZqpO12I10R2zZQNDCfC/liRoQRIRLY3GbSu+7Lw3jkBFrQwN/0+dEpU8Si1NwdWA6Bpvo4q1DnUEv44rHKv9uU+FCWZjVJIz1PjOwmhANbsrOUfvUPoEcR4GPhPg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1276; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1276;20:BoyoOOLngemtR9XIt0YRlg9wf60eVYrEN7dVV+LgxvCfhe59nnwU5iTUlpabogcv61NHQK+a48inLISkRA9rujn3wM+0I5tu56d/5hHfhKY8/BRmTes/wM7j+bDHRSCvTJDHLBhUIQ5RRz7JgiImlTHc+peGNSUzsCJ1yAhlMUChrluI/JzOhzxb5PSQ1clDO6guI3eMlkD5Wz9knOG5z0bskfc14aq2saw6b0mEpgx42lzSTME/DRSKzC0vFovbjlVgXmR0T6QoQb5D5kI7yuwOyUarQWNDqaCtt9a660Jqj0/eYADGl6xIfuj33NDLVgkFAsqavi0gqOcenOg/uVdmXgFLNcTi9Kj/uXN50rg=;4:ursTTyXdcuVf+1Tm2FX5rxLZ6sQ92ugfFBu2dDoTjECRrr+hO/11lf94fgwk706LrFstBq2S4e4nQUhYqSJ7OZi+DtPWYBNe1GM3SdwiigmrpgL5g/wXRDHoh/mJV5bhW+ViUXChZ9en1W0r40EAu4p8epIPqYxXke7OwKNn2gsV4y7Rc3/xrvf2yVydu67TxiWSmuD5DBs+8oRpMPpR/qMbSZh8M2LVdIK/b83wFCPKSlLcBtWdKg1+m75q3Ne+XcPQZZqob1iO1S//RT8o09QrVJ04Erns69WGdmGqSS6Dm/RGTG8P3ccVasUjiMm2W3SCYuM/b6HhhvQMuLy6A/beOuFdAw0Z58psvnohY94= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:CY1PR0301MB1276;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1276; X-Forefront-PRVS: 073515755F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1276;23:FrcIMyu+VDeMqWmlJcozA0LP/I28e/FR5bV8voC?= =?us-ascii?Q?p1mMywaSVzsTPWvf+XwH8wJpsmHyJuD0+FrIgn4lc2hRwORh6QRrizrpjV+4?= =?us-ascii?Q?8aWEWstnYV2pyXUR8/s1EazwupZRWM9kSVR47xrILA4qAfG2xp5EcLdxRu8V?= =?us-ascii?Q?ykrqzrjSowSNvcPrHShqdmWoG0bPY2Zf/RhharZbIxdpdoSzA82f4t7wwbGy?= =?us-ascii?Q?8lho9/RDr5A3XsjE/gEWC5D/91ZqIb8eJpd8uUxQGUbiXhPnD4o3hywLPt34?= =?us-ascii?Q?SV8KIYk3AjyT3ZmC44yZntDUOtZBKiWi/YZvWldnkHiD+zZJUnWlBFhjHq6z?= =?us-ascii?Q?pkoIOF9XZDmXDc1V37+yN50pu6VooBozaRRFdB8FhUP5LVwsRVJ2lZAiv+fh?= =?us-ascii?Q?dBCmeZRNPQhzCA77ROkRJm1y2JmC/PtRyVQYm2Mhqhjs8BJJ0ytnwxlcOe16?= =?us-ascii?Q?jVOkeojDlJYpeQWxw5k9lR1GEvl+LPWWqbzNe/U6O/lZ7WTDuwXahYK1PhEr?= =?us-ascii?Q?LxrmNR/pAjEsJhv3OccpLNoI3AurVHsJo/ECvZYSFIHbJAkWz4azfOtlmuR0?= =?us-ascii?Q?xovt80GJGjAjy1N2oxZJGfQ+PwGknFIJkgkLclQ6jOkryWEG1BhrM5EjvBjr?= =?us-ascii?Q?zVIIOcPd4ZU2vM92h9O0ZMCIAv3N7AkHCCPoMOCEqAdpOT8U2Hpyy5BPMG/k?= =?us-ascii?Q?mmRb/f+mfjxZQxol27fHnFFRZoQiBwDBDewffsygbGi18Il636UxFaJl6tEY?= =?us-ascii?Q?ugEtpJlwv2U5zvBv0zgyTzrYn24NNreVD5nzuY9IqfzHolo2R1DAG9FknTun?= =?us-ascii?Q?m7KmLmiQEzH/WC1LahanY/aAXF6Q7+CTLUrnk8+PDl9gtvTTIalEYPomqlkJ?= =?us-ascii?Q?Pv3pT5bUwiG1Zmn0Q2xoi88SsSu/LQkmOzjTkSsUaDlJKxrwScTYixTh6DwC?= =?us-ascii?Q?T2mdmT+v0guhw3ODefvPzDdoJ6fMTItUMLJ4/9cfYh5OaOnNbpAKVjobD9OS?= =?us-ascii?Q?dGhYyAIqzwR/Xczic5BVj4POopZYkfhaWbTJkUe4S4MJjrjub/gdglmC79Gn?= =?us-ascii?Q?tUJdi0jj3vs5ztHj8e3ukLsv3jNYgMHWG017jYBm+huskT53nZWMM+x9VwwN?= =?us-ascii?Q?2FKUro2xaF7c=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1276;5:E1mSv/jlX1g2/Ok5gNbtV2XYAmXPu00Pf7nLyg6TNtNwvHRwXjrq0zvnKlJynWmSbvq90LPZe3fuE82JNVY1Sd9MhEB+loxmAYGiwBmmcd8d8Igk3jkMmQh01ezMN3yBdzB5wNqDcnX2WMRMOjnLvQ==;24:fCLsO1F7di5fsAZUd1YXUY4sbTp1IbrZ67dwgqv7EY7PYWnd13jduZogWWhnQ61aoi0r/neLy/Yot59m6Z0UbD1E04v+xF93r8QKN9suj5w=;20:mLH+gPn4ImpiqK2yPLEq+WY8i93vR21jEkA54lk+Z7KG3ZPyex3i81nvZZhGOkQz0vzMoycoOUyKq3Ky3cfl7g== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2015 06:02:15.7954 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1276 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 11:29:18AM +0900, Jiada Wang wrote: > Currently in udc_stop, if vbus_active flag is true, all USB activities > will be stopped, but vbus_active flag is still left to be true, > this causes issue, when afterwards driver tries to connect gadget > device to host, But due to the uncleared vbus_active, some necessary > setup steps are skipped. > > This patch clears vbus_active flag in udc_stop callback. > > Signed-off-by: Jiada Wang > --- > drivers/usb/chipidea/udc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > index 8223fe7..b9ac228 100644 > --- a/drivers/usb/chipidea/udc.c > +++ b/drivers/usb/chipidea/udc.c > @@ -1762,6 +1762,7 @@ static int ci_udc_stop(struct usb_gadget *gadget) > spin_lock_irqsave(&ci->lock, flags); > > if (ci->vbus_active) { > + ci->vbus_active = 0; > hw_device_state(ci, 0); > if (ci->platdata->notify_event) > ci->platdata->notify_event(ci, > -- > 2.4.5 > This flag will be handled by vbus interrupt, would you please explain more what problem you have met? -- Best Regards, Peter Chen