From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752347AbbJTGfq (ORCPT ); Tue, 20 Oct 2015 02:35:46 -0400 Received: from mail-by2on0109.outbound.protection.outlook.com ([207.46.100.109]:22240 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752275AbbJTGfm (ORCPT ); Tue, 20 Oct 2015 02:35:42 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Tue, 20 Oct 2015 14:34:32 +0800 From: Peter Chen To: Jiada Wang CC: , , Subject: Re: [PATCH] usb: chipidea: udc: clear vbus_active flag in udc_stop Message-ID: <20151020063432.GB7203@shlinux2> References: <1445308158-23100-1-git-send-email-jiada_wang@mentor.com> <20151020060107.GA27364@shlinux2> <5625DA7E.8000601@mentor.com> <20151020062811.GA7203@shlinux2> <5625E050.6080107@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5625E050.6080107@mentor.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD051;1:vaDLx3noebE2pVirrx/O0jEN4gmmtu3Q+fztq7TOzgPgQx3sqt+AmqMgHq1xHkoM/WUWf6ur6qQy+v/VbVKO/t+iGC1JzL2i4pI1QrWTAHZgKBIdKk04TX7FfNK0BHs/SjC6MjMAeUVv9304n8iXPudDOj93aRGm0b+ET3kgn4VNjImMshZ8bzN8FJHQd43orRE0LLbQJ4S/ALYc9wDqYHcO9nnFBGWfCrk3b57pOrCAq1/5Jvs9yPfzXUCVIdnPcNFiR2PZG3xDqy8futfH9IgEK3Tqg1/5D8CNzZnddO+BKfG9eAOEJt1twmhHWJojzbjGqhYP4b6Z6U8dHb866yLFxWKyHcmdLEj9TXbHDqA64eGbW5/3ALGG306sM4ym X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(377454003)(189002)(199003)(479174004)(19580395003)(93886004)(23726002)(97756001)(19580405001)(76176999)(50986999)(47776003)(86362001)(4001350100001)(46406003)(50466002)(54356999)(85426001)(33656002)(46102003)(189998001)(81156007)(64706001)(5001960100002)(110136002)(105606002)(77096005)(97736004)(2950100001)(11100500001)(33716001)(92566002)(106466001)(83506001)(104016004)(87936001)(5008740100001)(5007970100001)(6806005);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR03MB496;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB496;2:yHfrgMCqAgzwmN8ydDZvHJN8CMOAG0CvfPs1WQFnHMaAeLqu8LZD9sSwxcOyXVQg6T0bkG5QJPhnHXtbP27toapH/p08imiDLjqBio+ASEEIewvnhJ78oa0Qx0Tm2TYF2cSTU8Uupc35CS/5PQ2ZpU/9HjwrDgvdrExvjRsZG7k=;3:Re7sqHBp0t9zJDgJMDigV1qSzfsWKswyyEEKS6BGvLjw6X871oKxZwokZtdICcLOvhbAo2RdcG3qYxh2tjsJnwH9VY2HFQOfaQR4WWBOule4sYr31gzB3kYeZnnW85yZonBX0iy5h20w+O92BRzqpxNweyZ9NgVzi3nl3ZJiP294uiYhQuNwtAAZTYPlCAMXTn0HvDVx6fgSYsf4SPMb5tUefGbV2AoNayQDwcYPiY0=;25:IRJ/xxYqtO1DyiJJ7qLVQKZRv82gKmc+gukZB4XG2xKY222SH4+SoM+OMiJKeUTc1oTbJk0/XRg8VjMt75m4imunSz4gVtaUKCgEVPJNSvVJ8Q0I2M9l3mrsyeZXsZqprdCkW3HDDxXuk6D4Q4YwLGyUbCJcNiL7yHeMI54XjPM7p3ckX4RRBkJb5x4PWZxhmzW0dp3Z/7moHGJBnsC4P2iXoojT0gWeJNi8fF43aD4WK2POrUMt39f0xhRS8uUjc+cRZVzIh+POKKTF5+bx4Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB496; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB496;20:0a8zXETADawjxqnGCFYwiOiZifYdWdGvDAykzGUFfo63Yvm/9E2oZsCvoKFY0vyr+STbWg7WS8tu3tc0jRib7TD2pvwf8axa6hZztViPmWcO9XMzr4se3rmWpFN3wvgDUcWpeekBE8DAFDO67owVCTAc6dWscUxMat7iJLJYqOxhSeu9DAjDIo2sTQ/hZXxfCWLK3asUK/zii38CsnAKuj656xrFVnbW+vrpg+pw5gZ8GazcenOKMJNNvi8v+8xp3C/YqZhDtdJmifvmrLWMWJoA/OsBkyKlb/d5akxHOw5D74WsieuFo4rOsAuoEp+7qmxMiBwLCqHxKKYjVMbe+0rO4zZwB5Z1bTlonnsstds=;4:OwN9qp6lWrW6bL35PBsP607lJH+go8ItC2UebRQ5BO24MDG94lWlXAVyWh88r3dAmBmVYFAm4sJYefvUkeTly73lcbY+lN3MDoz6h544LbFd2SvaS+ivUZTwKay2xSJrakd0HrZrWWDlLkozkpQB6P3edTHwcEjdpx0+GJhZvyTa5cj3hlOWve5XOANftcvnXUkTtsu7aZmYyrAZ117MhhkjthnCgzPOf+XB8YUdzLcHRXc5wtQhbqAjtmGUjNFMdjCK9rO2PKc7IQdzAM5DaZMzhVOAc3oczc4oy9WMn5bQO1RtS22R2LCEPX5oSqHR3J4h+9Ku5zKnmif0A8okcx1n6cpZlw819Gv7J7yzjIA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:DM2PR03MB496;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB496; X-Forefront-PRVS: 073515755F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR03MB496;23:1PpCRZLvdinuW3ZRAdLX54YLFOM5yEA+PGXjl7uVOx?= =?us-ascii?Q?UbsUmgW5U7aPP6uadMoJ24Xu6VjqHhuhiq0cvgV++2tuW+H6Uzu+UpS/Qnko?= =?us-ascii?Q?Wnn2dTiq3dzWmhf8rEaKJjvKyxVEqFQhQdsAfpJtcst+qxAHK6uRIJbo5abG?= =?us-ascii?Q?OXWu8p9A8nCen2VPv43wSym8onvW4mNX2KoyeVvCvr5KY7TNg15zg2Dpbixf?= =?us-ascii?Q?IE/fAE+s0tXBFAh3nN+43/UlUMWZHEpQSdDeae0G17Y9ULLLMMot0WrS1rPV?= =?us-ascii?Q?0Y/uVClmuuKLl1hS7XwKVBwIvepi4xsM38JHCqfErBzzxajDxmoMgieSJ3TP?= =?us-ascii?Q?J/fcmFCnyH6c5Nel0DmQ1fR0dZD5H+3WGN68N9mAYmx9R/7uZQaT5ygKztkZ?= =?us-ascii?Q?vTJ4zZNIxmKfi4M+IlUOVSYMCQxBN+RsBL06El+eFR7zHK1vgGskKNdekC39?= =?us-ascii?Q?QITkNvgqVFxb4QeAoaPIizvdzzyqU5huHXMsIApJuTeA+RM2E+LLGHKa9nH/?= =?us-ascii?Q?7HZkWWNvmi3V8eK8zv6IRbMJ/8u/lWDTu6If9xjaC+kB5pM8AtO914W+JnfA?= =?us-ascii?Q?o/18ru+64Kb8rySijhusBDrWOF9XXDcb5udZwqsCNeUXFXvO+9S30pCoeCXi?= =?us-ascii?Q?iPIo0dGLsemxKKoG2P89zlJV+ep8mynXndmEmufzbLZ5xRNVuaIsBfmKcyUp?= =?us-ascii?Q?rIS+DAr/OTc6K/UOVoLFS8dk1zpvuaD8ms66qc8OtRyxWeEjNzPqdacA3WGB?= =?us-ascii?Q?OmvaI4GIT6H3nP53MNCGBJgDABQNX67d+TtYTdIdlJ3kkiDXzcQ+OIQBJTp+?= =?us-ascii?Q?GBlgv1L6corFgoOd+12yCITXUr1+JzJznlh6v+/0XEInTS9ueVmDVNvY5n1E?= =?us-ascii?Q?0+jcc7iv0IVIPsuxOus4t1ANnoezEEOnueXwVw5pNHOlPpN+6cfk1lj6azfH?= =?us-ascii?Q?Crs9URFGbqMvxhes/5/JVClhhsaaqb5vQ5jvV8YB+NbTxu8vTttEypGPPZ1L?= =?us-ascii?Q?RvP2PeyigYGunl/aHCep6KirCvOoskuiiDSPpEau9vKH4MHuJsvWJAOPJJIY?= =?us-ascii?Q?Is1eigrOV8DQ8DLh1CcuIfUCPEARsXgWeqryug6w6+9uiLLDxiX9rZC+7Rh3?= =?us-ascii?Q?Q2SsNT1pQ0Vv6n0bUmf3oa7+fcSha4BHDVSljDZZ0LNmyMyNpZRD59YCMR4d?= =?us-ascii?Q?6UKpqPWrgsVUMqcFE0qF7HNJgdXwoutT3J?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB496;5:f4WPCZ/VWZPC12Zs9H5vi+BEC6jfTvcv8Npy3UtWwnp83Dse3Z6HNfIsP2BubJ6WyyzDMtII38h2u0ZRYBvm66H1PdpSCiq8awkfH50wKw9eSE87PD0VOBLz+AnsZRd7zMyL3YlqQhQyDqSbsqz7kQ==;24:AfFiseUndrvK/cfNb5EamVyne4tKC065qIlHBthIs33MsYQgPY2DiXSZ/wrXPaODLkTsR4Gt+zf8IR3rDuALO8nSmc8IQgpEydVkUm6yr7g=;20:0xT13A+Ju/O/3FKDFBmtk4YU9hM3n7YhPmP0I6vKihSpHydoBmtB8+WLTN7trLGyi0s+vZYXwHkUqthpYgwrTA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2015 06:35:39.6557 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB496 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 03:33:52PM +0900, Jiada Wang wrote: > Hi > > On 10/20/2015 03:28 PM, Peter Chen wrote: > >On Tue, Oct 20, 2015 at 03:09:02PM +0900, Jiada Wang wrote: > >>Hi > >> > >>On 10/20/2015 03:01 PM, Peter Chen wrote: > >>>On Tue, Oct 20, 2015 at 11:29:18AM +0900, Jiada Wang wrote: > >>>>Currently in udc_stop, if vbus_active flag is true, all USB activities > >>>>will be stopped, but vbus_active flag is still left to be true, > >>>>this causes issue, when afterwards driver tries to connect gadget > >>>>device to host, But due to the uncleared vbus_active, some necessary > >>>>setup steps are skipped. > >>>> > >>>>This patch clears vbus_active flag in udc_stop callback. > >>>> > >>>>Signed-off-by: Jiada Wang > >>>>--- > >>>> drivers/usb/chipidea/udc.c | 1 + > >>>> 1 file changed, 1 insertion(+) > >>>> > >>>>diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > >>>>index 8223fe7..b9ac228 100644 > >>>>--- a/drivers/usb/chipidea/udc.c > >>>>+++ b/drivers/usb/chipidea/udc.c > >>>>@@ -1762,6 +1762,7 @@ static int ci_udc_stop(struct usb_gadget *gadget) > >>>> spin_lock_irqsave(&ci->lock, flags); > >>>> > >>>> if (ci->vbus_active) { > >>>>+ ci->vbus_active = 0; > >>>> hw_device_state(ci, 0); > >>>> if (ci->platdata->notify_event) > >>>> ci->platdata->notify_event(ci, > >>>>-- > >>>>2.4.5 > >>>> > >>> > >>>This flag will be handled by vbus interrupt, would you please explain > >>>more what problem you have met? > >>the actual issue I had is, > >>build kernel with USB_OTG_FSM enabled, > >>keep usb cable plugged, > >>load/unload USB gadget module (for example I tried g_zero or g_serial), > >>after unload gadget module once, then the status of vbus_active is not > >>correct, > >>this causes host machine failed to detect gadget device when later > >>gadget device module is loaded again. > >> > >> > > > >ci->vbus_active is only used at non-fsm mode, would you please try below > >fix? > > > >usb: chipidea: otg: gadget module load and unload support > > > >This patch is to support load and unload gadget driver in full OTG mode. > > > >Acked-by: Peter Chen > >Signed-off-by: Li Jun > >--- > > drivers/usb/chipidea/udc.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > >diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > >index e19d8b8..67cfa04 100644 > >--- a/drivers/usb/chipidea/udc.c > >+++ b/drivers/usb/chipidea/udc.c > >@@ -1755,6 +1755,22 @@ static int ci_udc_start(struct usb_gadget *gadget, > > return retval; > > } > > > >+static void ci_udc_stop_for_otg_fsm(struct ci_hdrc *ci) > >+{ > >+ if (!ci_otg_is_fsm_mode(ci)) > >+ return; > >+ > >+ mutex_lock(&ci->fsm.lock); > >+ if (ci->fsm.otg->state == OTG_STATE_A_PERIPHERAL) { > >+ ci->fsm.a_bidl_adis_tmout = 1; > >+ ci_hdrc_otg_fsm_start(ci); > >+ } else if (ci->fsm.otg->state == OTG_STATE_B_PERIPHERAL) { > >+ ci->fsm.protocol = PROTO_UNDEF; > >+ ci->fsm.otg->state = OTG_STATE_UNDEFINED; > >+ } > >+ mutex_unlock(&ci->fsm.lock); > >+} > >+ > > /** > > * ci_udc_stop: unregister a gadget driver > > */ > >@@ -1779,6 +1795,7 @@ static int ci_udc_stop(struct usb_gadget *gadget) > > ci->driver = NULL; > > spin_unlock_irqrestore(&ci->lock, flags); > > > >+ ci_udc_stop_for_otg_fsm(ci); > > return 0; > > } > > > > > > I will test with this patch and come back with the result, > has this patch been submitted to community? > I am afraid it is not, please add your tested-by if it fixes your problem, I will queue it as a bug-fix. -- Best Regards, Peter Chen