From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753103AbbJTJP6 (ORCPT ); Tue, 20 Oct 2015 05:15:58 -0400 Received: from down.free-electrons.com ([37.187.137.238]:48269 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751596AbbJTJPz (ORCPT ); Tue, 20 Oct 2015 05:15:55 -0400 Date: Tue, 20 Oct 2015 11:15:52 +0200 From: Boris Brezillon To: Richard Weinberger Cc: David Woodhouse , Brian Norris , "linux-mtd@lists.infradead.org" , Maxime Ripard , linux-sunxi@googlegroups.com, Hans de Goede , "linux-arm-kernel@lists.infradead.org" , LKML Subject: Re: [PATCH 2/3] mtd: nand: add NAND_NEED_SCRAMBLING flag to the H27UCG8T2ATR-BC definition Message-ID: <20151020111552.33d4c23f@bbrezillon> In-Reply-To: References: <1444929443-25537-1-git-send-email-boris.brezillon@free-electrons.com> <1444929443-25537-3-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2015 09:20:10 +0200 Richard Weinberger wrote: > On Thu, Oct 15, 2015 at 7:17 PM, Boris Brezillon > wrote: > > The H27UCG8T2ATR-BC requires an external data scrambler. Reflect this > > constraint in the nand_flash_ids definition. > > > > Signed-off-by: Boris Brezillon > > --- > > drivers/mtd/nand/nand_ids.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c > > index a8804a3..ccc05f5 100644 > > --- a/drivers/mtd/nand/nand_ids.c > > +++ b/drivers/mtd/nand/nand_ids.c > > @@ -50,8 +50,8 @@ struct nand_flash_dev nand_flash_ids[] = { > > SZ_16K, SZ_8K, SZ_4M, 0, 6, 1280, NAND_ECC_INFO(40, SZ_1K) }, > > {"H27UCG8T2ATR-BC 64G 3.3V 8-bit", > > { .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} }, > > - SZ_8K, SZ_8K, SZ_2M, 0, 6, 640, NAND_ECC_INFO(40, SZ_1K), > > - 4 }, > > + SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640, > > + NAND_ECC_INFO(40, SZ_1K), 4 }, > > Would it make sense to print a warning if a NAND which needs scrambling > is used on a NFC which does not support this feature? > Maybe, but if we want to make this warning generic this implies adding a new NAND_CONTROLLER_SUPPORTS_SCRAMBLING flag. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com