From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbbJTNCz (ORCPT ); Tue, 20 Oct 2015 09:02:55 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:32885 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbbJTNCx (ORCPT ); Tue, 20 Oct 2015 09:02:53 -0400 Date: Tue, 20 Oct 2015 15:02:56 +0200 From: Johan Hovold To: Konstantin Shkolnyy Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] USB: serial: cp210x: Implement 16-bit register access functions Message-ID: <20151020130256.GE20289@localhost> References: <1445292084-27910-1-git-send-email-konstantin.shkolnyy@gmail.com> <20151020074516.GA20289@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 07:52:31AM -0500, Konstantin Shkolnyy wrote: > On Tue, Oct 20, 2015 at 2:45 AM, Johan Hovold wrote: > [...] > > Instead of adding the new helpers to read u16 as a prerequisite for > > fixing the broken cp2108 support, just reuse the current config register > > helpers for now (in order to keep the fixes minimal and potentially > > backportable). Once the fixes are in place, feel free to clean up the > > remaining register accesses. > > The current helpers take "port" as a parameter. You pointed out > previously that port shouldn't be used in probe(). That made me > implement new helpers cp210x_write_u16_reg and cp210x_read_u16_reg > that don't use port. Probe() now calls cp210x_activate_workarounds > which in turn calls these new helpers. Oh, that's right. > An alternative would be to call usb_control_msg from > cp210x_activate_workarounds, but I think it would make it look pretty > ugly. Or you move the quirk-detect (and private data allocation) to port_probe instead (and remove startup/release). These devices have exactly one port per interface, so you wouldn't introduce any redundancy. Johan