From: Jason Cooper <jason@lakedaemon.net>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH 5/5] irqchip: armada-370-xp: document the overall driver logic
Date: Tue, 20 Oct 2015 14:07:34 +0000 [thread overview]
Message-ID: <20151020140734.GF3953@io.lakedaemon.net> (raw)
In-Reply-To: <20151020160021.374725f3@free-electrons.com>
On Tue, Oct 20, 2015 at 04:00:21PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 20 Oct 2015 15:23:55 +0200, Thomas Petazzoni wrote:
>
> > +/*
> > + * Overall diagram of the Armada XP interrupt controller:
> > + *
> > + * To CPU 0 To CPU 1
> > + *
> > + * /\ /\
> > + * || ||
> > + * +---------------+ +---------------+
> > + * | | | |
>
> Things are a bit off here.
>
> > + * | per-CPU | | per-CPU |
> > + * | mask/unmask | | mask/unmask |
> > + * | CPU0 | | CPU1 |
> > + * | | | |
> > + * +---------------+ +---------------+
> > + * /\ /\
>
> and here. So I can fix that up in the next version.
>
> If we're doing ASCII art, let's do it properly.
Agreed. It's not pressing. You can resubmit these last two separately
and we'll cue them up for 4.4.
thx,
Jason.
next prev parent reply other threads:[~2015-10-20 14:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:23 [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 1/5] kernel: irq: implement is_enabled_percpu_irq() Thomas Petazzoni
2015-12-08 11:57 ` [tip:irq/core] genirq: Implement irq_percpu_is_enabled() tip-bot for Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 2/5] irqchip: armada-370-xp: prepare additions to armada_xp_mpic_secondary_init() Thomas Petazzoni
2015-10-20 14:00 ` Gregory CLEMENT
2015-10-20 13:23 ` [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Thomas Petazzoni
2015-10-20 13:46 ` Gregory CLEMENT
2015-10-20 13:50 ` Thomas Petazzoni
2015-10-25 21:22 ` Marcin Wojtas
2015-10-26 0:10 ` Thomas Petazzoni
2015-10-26 4:35 ` Marcin Wojtas
2015-10-26 5:09 ` Thomas Petazzoni
2015-10-26 7:06 ` Marcin Wojtas
2015-10-26 8:27 ` Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 4/5] irqchip: armada-370-xp: re-order register definitions Thomas Petazzoni
2015-10-20 13:55 ` Gregory CLEMENT
2015-10-20 13:23 ` [PATCH 5/5] irqchip: armada-370-xp: document the overall driver logic Thomas Petazzoni
2015-10-20 13:59 ` Gregory CLEMENT
2015-10-20 14:00 ` Thomas Petazzoni
2015-10-20 14:07 ` Jason Cooper [this message]
2015-10-20 14:04 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Jason Cooper
2015-10-20 14:08 ` Thomas Petazzoni
2015-10-20 14:17 ` Russell King - ARM Linux
2015-10-20 14:23 ` Thomas Petazzoni
2015-10-20 19:24 ` Thomas Gleixner
2015-10-22 8:01 ` Thomas Gleixner
2015-10-20 19:23 ` Thomas Gleixner
2015-10-21 13:48 ` [PATCH] irqchip: irq-armada-370-xp: fix regression by clearing IRQ_NOAUTOEN Thomas Petazzoni
2015-10-21 14:41 ` Jason Cooper
2015-10-21 13:49 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni
2015-11-11 8:26 ` Thomas Petazzoni
2015-11-13 20:11 ` Thomas Gleixner
2015-12-04 11:03 ` Thomas Petazzoni
2015-12-05 17:24 ` Thomas Gleixner
2015-12-06 9:28 ` Thomas Gleixner
2015-12-08 8:58 ` Thomas Petazzoni
2015-12-08 10:54 ` Thomas Gleixner
2017-02-24 16:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020140734.GF3953@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).