From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Andreas Ziegler <andreas.ziegler@fau.de>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Valentin Rothberg <rothberg@cs.fau.de>,
Paul Bolle <pebolle@tiscali.nl>
Subject: Re: tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0
Date: Tue, 20 Oct 2015 17:58:35 +0300 [thread overview]
Message-ID: <20151020145835.GA6186@intel.com> (raw)
In-Reply-To: <56262A2E.6040602@fau.de>
On Tue, Oct 20, 2015 at 01:49:02PM +0200, Andreas Ziegler wrote:
> Hi Jarkko,
>
> your patch "tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0"
> showed up as commit 399235dc6e95 in linux-next today (that is,
> next-20151020). I noticed it because we (a research group from
> Erlangen[0]) are running daily checks on linux-next.
>
> Your commit creates the following structure of #ifdef blocks in
> drivers/char/tpm/tpm_tis.c following line 1088:
>
> #ifdef CONFIG_ACPI
> ...
> #ifdef CONFIG_PNP
> ...
> #endif
> ...
> #endif
>
> Looking at the definition of CONFIG_ACPI at drivers/acpi/Kconfig, line
> 5, we see that ACPI unconditionally selects PNP, meaning that CONFIG_PNP
> is always enabled if CONFIG_ACPI has been enabled.
> Thus, the inner #ifdef statement can never evaluate to 'false' if the
> outer #ifdef evaluates to true (i.e., CONFIG_ACPI is enabled), and
> hence, the #ifdef is unnecessary.
>
> The same situation holds for the nested structure following line 1124,
> where the #ifdef CONFIG_PNP at line 1129 is unnecessary.
>
> Is this correct or did we miss something?
Good catch. Shoud I send a separate fix for this? Thanks for pointing
this out.
> Regards,
>
> Andreas
>
> [0] https://cados.cs.fau.de
/Jarkko
next prev parent reply other threads:[~2015-10-20 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 11:49 tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0 Andreas Ziegler
2015-10-20 14:58 ` Jarkko Sakkinen [this message]
2015-10-21 15:58 ` [tpmdd-devel] " Jarkko Sakkinen
2015-10-23 13:01 ` Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020145835.GA6186@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=andreas.ziegler@fau.de \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peterhuewe@gmx.de \
--cc=rothberg@cs.fau.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).