From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959AbbJTPK6 (ORCPT ); Tue, 20 Oct 2015 11:10:58 -0400 Received: from down.free-electrons.com ([37.187.137.238]:57511 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751965AbbJTPKz (ORCPT ); Tue, 20 Oct 2015 11:10:55 -0400 Date: Tue, 20 Oct 2015 17:10:52 +0200 From: Alexandre Belloni To: Paul Gortmaker Cc: Greg Kroah-Hartman , linux-soc@vger.kernel.org, Michael Ellerman , linux-arm-msm@vger.kernel.org, Andy Gross , Nicolas Ferre , linux-kernel@vger.kernel.org, Kumar Gala , linux-mediatek@lists.infradead.org, Anton Blanchard , linux-serial@vger.kernel.org, Jiri Slaby , Matthias Brugger , David Brown , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular Message-ID: <20151020151052.GI3421@piout.net> References: <1445206878-12455-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445206878-12455-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/2015 at 18:21:13 -0400, Paul Gortmaker wrote : > The one common thread here for all the patches is that we also > scrap the .remove functions which would only be used for module > unload (impossible) and driver unbind. For the drivers here, there > doesn't seem to be a sensible unbind use case (vs. e.g. a multiport > PCI ethernet driver where one port is unbound and passed through to > a kvm guest or similar). Hence we just explicitly disallow any > driver unbind operations to help prevent root from doing something > illogical to the machine that they could have done previously. > > We've already done this for drivers/tty/serial/mpsc.c previously. > > Build tested for allmodconfig on ARM64 and powerpc for tty/tty-testing. > So, how does this actually build test atmel_serial? A proper solution would be to actually make it a tristate and allow building as a module. I think it currently fails because of console_initcall() but that is certainly fixable. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com