From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbbJTPQG (ORCPT ); Tue, 20 Oct 2015 11:16:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:53744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbbJTPQD (ORCPT ); Tue, 20 Oct 2015 11:16:03 -0400 Date: Tue, 20 Oct 2015 12:15:58 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: ast@plumgrid.com, brendan.d.gregg@gmail.com, a.p.zijlstra@chello.nl, daniel@iogearbox.net, dsahern@gmail.com, hekuang@huawei.com, jolsa@kernel.org, lizefan@huawei.com, masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, paulus@samba.org, linux-kernel@vger.kernel.org, pi3orama@163.com, xiakaixu@huawei.com Subject: Re: [PATCH 03/31] perf tools: Enable passing bpf object file to --event Message-ID: <20151020151558.GG5119@kernel.org> References: <1444826502-49291-1-git-send-email-wangnan0@huawei.com> <1444826502-49291-4-git-send-email-wangnan0@huawei.com> <20151020151255.GF5119@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151020151255.GF5119@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 20, 2015 at 12:12:55PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Oct 14, 2015 at 12:41:14PM +0000, Wang Nan escreveu: > > By introducing new rules in tools/perf/util/parse-events.[ly], this > > patch enables 'perf record --event bpf_file.o' to select events by an > > eBPF object file. It calls parse_events_load_bpf() to load that file, > > which uses bpf__prepare_load() and finally calls bpf_object__open() for > > the object files. > > > > After applying this patch, commands like: > > > > # perf record --event foo.o sleep > > > > become possible. > > So, trying the above command I get almost perfect output: > > [root@felicio ~]# perf record --event foo.o sleep > libbpf: failed to open foo.o: No such file or directory > event syntax error: 'foo.o' > \___ BPF object file 'foo.o' is invalid > > (add -v to see detail) > Run 'perf list' for a list of valid events > > Usage: perf record [] [] > or: perf record [] -- [] > > -e, --event event selector. use 'perf list' to list available events > [root@felicio ~]# > > > Good thing would be to not have any message from libbpf and the right error > message from the parser, i.e. the first three lines become these two: > > > event syntax error: 'foo.o' > \___ BPF object file 'foo.o' not found.o > > But that can be fixed up in an upcoming patch, so I am applying this one now in > my new attempt at processing this patchkit. Ditto for: [acme@felicio linux]$ perf record --event /tmp/build/perf/perf.o sleep libbpf: /tmp/build/perf/perf.o is not an eBPF object file event syntax error: '/tmp/build/perf/perf.o' \___ BPF object file '/tmp/build/perf/perf.o' is invalid (add -v to see detail) Run 'perf list' for a list of valid events Usage: perf record [] [] or: perf record [] -- [] -e, --event event selector. use 'perf list' to list available events [acme@felicio linux]$ Now trying to find a _valid_ ebpf object file to test with. - Arnaldo