From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013AbbJTOId (ORCPT ); Tue, 20 Oct 2015 10:08:33 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56050 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752160AbbJTOIb (ORCPT ); Tue, 20 Oct 2015 10:08:31 -0400 Date: Tue, 20 Oct 2015 16:08:28 +0200 From: Thomas Petazzoni To: Jason Cooper Cc: Thomas Gleixner , Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tawfik Bayouk , Nadav Haklai , Lior Amsalem , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement Subject: Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Message-ID: <20151020160828.497fcc80@free-electrons.com> In-Reply-To: <20151020140427.GE3953@io.lakedaemon.net> References: <1445347435-2333-1-git-send-email-thomas.petazzoni@free-electrons.com> <20151020140427.GE3953@io.lakedaemon.net> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason, On Tue, 20 Oct 2015 14:04:27 +0000, Jason Cooper wrote: > Whole series, > > Reviewed by: Jason Cooper Thanks. > Thomas (tglx), if you're happy with the core changes, let me know and > I'll cue the series up. > > We know it's a bit late in the -rc cycle, but the alternative (reverting > Rob's patch) would likely be more destabilizing at this point. As discussed on IRC, another simpler (code line wise) solution is to simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which brings us back to what set_irq_flags() was doing, without actually reverting Rob's patch. However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the right long term solution, which is why I implemented what I believe is a (hopefully) better long term solution. But if you/tglx want something simple/stupid for 4.3 (one-line patch) and then the real stuff for 4.4, I'd be happy to provide a series implementing this idea. Let me know what you and tglx think. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com