linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rcu: remove rcu_user_hooks_switch
@ 2015-10-19 21:45 Yang Shi
  2015-10-19 22:59 ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Yang Shi @ 2015-10-19 21:45 UTC (permalink / raw)
  To: fweisbec, paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai
  Cc: linux-kernel, linaro-kernel, yang.shi

It is not invoked by anyone now, just remove it.

Signed-off-by: Yang Shi <yang.shi@linaro.org>
---
 include/linux/rcupdate.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index 581abf8..56355bc 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -345,8 +345,6 @@ void rcu_user_exit(void);
 #else
 static inline void rcu_user_enter(void) { }
 static inline void rcu_user_exit(void) { }
-static inline void rcu_user_hooks_switch(struct task_struct *prev,
-					 struct task_struct *next) { }
 #endif /* CONFIG_NO_HZ_FULL */
 
 #ifdef CONFIG_RCU_NOCB_CPU
-- 
2.0.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] rcu: remove rcu_user_hooks_switch
  2015-10-19 21:45 [PATCH] rcu: remove rcu_user_hooks_switch Yang Shi
@ 2015-10-19 22:59 ` Paul E. McKenney
  2015-10-19 23:46   ` Frederic Weisbecker
  0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2015-10-19 22:59 UTC (permalink / raw)
  To: Yang Shi
  Cc: fweisbec, josh, rostedt, mathieu.desnoyers, jiangshanlai,
	linux-kernel, linaro-kernel

On Mon, Oct 19, 2015 at 02:45:02PM -0700, Yang Shi wrote:
> It is not invoked by anyone now, just remove it.
> 
> Signed-off-by: Yang Shi <yang.shi@linaro.org>

We should check with Frederic -- any plans to use this, Frederic?
It was last touched by commit 4d9a5d4319e2 (rcu: Remove rcu_switch())
back in 2012.

							Thanx, Paul

> ---
>  include/linux/rcupdate.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index 581abf8..56355bc 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -345,8 +345,6 @@ void rcu_user_exit(void);
>  #else
>  static inline void rcu_user_enter(void) { }
>  static inline void rcu_user_exit(void) { }
> -static inline void rcu_user_hooks_switch(struct task_struct *prev,
> -					 struct task_struct *next) { }
>  #endif /* CONFIG_NO_HZ_FULL */
> 
>  #ifdef CONFIG_RCU_NOCB_CPU
> -- 
> 2.0.2
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rcu: remove rcu_user_hooks_switch
  2015-10-19 22:59 ` Paul E. McKenney
@ 2015-10-19 23:46   ` Frederic Weisbecker
  2015-10-20 20:35     ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Frederic Weisbecker @ 2015-10-19 23:46 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Yang Shi, josh, rostedt, mathieu.desnoyers, jiangshanlai,
	linux-kernel, linaro-kernel

On Mon, Oct 19, 2015 at 03:59:07PM -0700, Paul E. McKenney wrote:
> On Mon, Oct 19, 2015 at 02:45:02PM -0700, Yang Shi wrote:
> > It is not invoked by anyone now, just remove it.
> > 
> > Signed-off-by: Yang Shi <yang.shi@linaro.org>
> 
> We should check with Frederic -- any plans to use this, Frederic?
> It was last touched by commit 4d9a5d4319e2 (rcu: Remove rcu_switch())
> back in 2012.

Not at all, feel free to remove it with my ACK!

Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rcu: remove rcu_user_hooks_switch
  2015-10-19 23:46   ` Frederic Weisbecker
@ 2015-10-20 20:35     ` Paul E. McKenney
  0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2015-10-20 20:35 UTC (permalink / raw)
  To: Frederic Weisbecker
  Cc: Yang Shi, josh, rostedt, mathieu.desnoyers, jiangshanlai,
	linux-kernel, linaro-kernel

On Tue, Oct 20, 2015 at 01:46:03AM +0200, Frederic Weisbecker wrote:
> On Mon, Oct 19, 2015 at 03:59:07PM -0700, Paul E. McKenney wrote:
> > On Mon, Oct 19, 2015 at 02:45:02PM -0700, Yang Shi wrote:
> > > It is not invoked by anyone now, just remove it.
> > > 
> > > Signed-off-by: Yang Shi <yang.shi@linaro.org>
> > 
> > We should check with Frederic -- any plans to use this, Frederic?
> > It was last touched by commit 4d9a5d4319e2 (rcu: Remove rcu_switch())
> > back in 2012.
> 
> Not at all, feel free to remove it with my ACK!

Very good, queued for testing and review with your ack.

							Thanx, Paul


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-10-20 20:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-19 21:45 [PATCH] rcu: remove rcu_user_hooks_switch Yang Shi
2015-10-19 22:59 ` Paul E. McKenney
2015-10-19 23:46   ` Frederic Weisbecker
2015-10-20 20:35     ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).