From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbJUCma (ORCPT ); Tue, 20 Oct 2015 22:42:30 -0400 Received: from mail-bl2on0075.outbound.protection.outlook.com ([65.55.169.75]:56960 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751889AbbJUCm3 (ORCPT ); Tue, 20 Oct 2015 22:42:29 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; 01.org; dkim=none (message not signed) header.d=none;01.org; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWJU6L-07-4N8-02 X-M-MSG: Date: Wed, 21 Oct 2015 10:40:03 +0800 From: Huang Rui To: Guenter Roeck CC: kbuild test robot , Yuanhan Liu , Fengguang Wu , , Borislav Petkov , Peter Zijlstra , Jean Delvare , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , Len Brown , "John Stultz" , =?utf-8?B?RnLvv71k77+9cmlj?= Weisbecker , , , , Andreas Herrmann , Aravind Gopalakrishnan , Borislav Petkov , Aaron Lu , Tony Li Subject: Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power Message-ID: <20151021024002.GB26968@hr-amur2> References: <1445308109-17970-6-git-send-email-ray.huang@amd.com> <201510201509.U8tGXwCz%fengguang.wu@intel.com> <20151021014214.GA26968@hr-amur2> <5626F53D.2090009@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5626F53D.2090009@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(199003)(377454003)(189002)(164054003)(24454002)(479174004)(19580395003)(33716001)(4001350100001)(2950100001)(189998001)(87936001)(15975445007)(97736004)(77096005)(86362001)(83506001)(5007970100001)(50466002)(11100500001)(23726002)(105586002)(106466001)(5890100001)(64706001)(93886004)(33656002)(47776003)(46406003)(101416001)(110136002)(5008740100001)(97756001)(50986999)(54356999)(46102003)(76176999)(92566002)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR12MB0860;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0860;2:o61NcGZBVF5bi47g+TeIvA1OED+g2YvBviHOFxJA2ZWol70U8uMxzKliFS8axQqq/nzyMge+k8nyUBmds5d3ikKcuKaL4F6GkbVwO1t7xNEDoO1U/Hd51BBh+wzXn2FUOIIasubrLFuVWHuzhKHh5dLxHPGSQ85Kq3BrXVEreOg=;3:4OtFdgy+VVe1t2IMmv41B4BiFRSE58Gu2opbXCg6miziWqqbTs/tbMWdypBt0v7erJyknhhsJ0IMocPnI6YxqYvMK+5DkuP0Hw7t2kvoJBdkFBESLG0MUOPJK/0T4VTTuS2EmttMSt6jd0jj25L3hIi4I9C4FbJOpyOmoFdjH7sGbaGUsT2H1+9jY+SNrCqD1FX3/f7dKbVv7NGevBdN9JXojOXBpQf42Q+RZdFH0lDL7gqVUKhyRW5LRbuMVs/A;25:vru5NqgjQOTzZ1RQBXfJK/QEgUrLCGhBRIU89p5EbzxzHrNCyez+M0cMqb9mlXdS8r1pzH3BJfZdf59zvBmLc0G6Zf3LEMa4mFibCAbZ4TeaY7DEZt8H5lFcc1UBIL2aOR9lLUMTnuJrzIk5TKWrHE0KKD0rF8X1KsKpdhzdfXYxq/K5scTRunBK50xLwMG/09OZzT+VuNisDdR46a/WBWp0SAbujggPFCJa/eKybb4+x9O5WTQnqz1xqJfRYzLmd3kJt2aX/cjIX5hf/rOZzQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR12MB0860; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0860;20:ltS6njq7r/IohI5oW8KVcyc30P4NiCUUD3kXRmmN3iA35kiWltJarKVXzrmLqQ43O/76gKU4MJRTCsce0wiGsiVZ8CERd7WQpjuUWUJOAnE+SjP4K8SqrUhbe1o+TR2QlDI/vJG1CWMjWCwfxmuq7XUqWcH1YCDhNkQNrqbbeZLprDW9XDTqyGAzOP1arBd8r+8q4iCfGdSYsGm7UfIzI5UttqAx326+9XA5GPOE0BQdmVFuox2vIgxQwMdaptXcY8u5cj7IcvcB37+Xbaz7OGKs06Y1sj/7kQ4IJ9czl/o8w6LWXONmwlP7tnaVMDtDFuum3Ck2ls2zwqbYWpeK+i73HdGtInZ508+fEH7PXNG5nga8wBXMaySWhNuXw2t1dd4lvzgsRxOczj1UQ/ZzO7GWtQFBKlt4R3bp3Qm8Hz0Ll0z2/1r56FWa3I8/UQ8T2x8NekG6KDmkSoCtCyoahhi+iSPOZaLztyppPiIRWEgzx+5UK92PerRcPeFQanTP;4:3Oja+bI/9RNnZGRM8Sg9ysN2PkgA+fF0kmdsuVSuy/wRBncBPGrYFHEZw3e38wwYHjQy3kxmwtPnBqcCYeX6dQPGM6mcTPG5AddpUVwtjcJd6BVYvKfTDah/Jztvbm5qN4L9800s1W6EIay0v/kqwhwwMxAcNHKf/wGPnSeUTAauLG4MQbxbojQhywuKG9kok8qWqaYGtwBG3aLsNMK8pnAA8khlj9nfpJl/+5SNSwb2CSA4qRzBtqM4jlBcHzmYaQMxZHdNhWkqCiJOUUaQdxQBH5ZEZZtdncRdS4yamhlnA5TwUx8hEHjifOzB70rqHVFr+yaniWw8YGFtmZxDcYiPgPwnlZ0QgN1ymgoyaO0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:DM3PR12MB0860;BCL:0;PCL:0;RULEID:;SRVR:DM3PR12MB0860; X-Forefront-PRVS: 073631BD3D X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR12MB0860;23:TJMgXj1dbIg+f87CqT10tsh2bRZwResBf5iLf5qTg?= =?us-ascii?Q?EHeAhVn8OqbNbja/fyBA/AaKmaqMq8t5EdZBwzVoKo+foDxAEzrxsOaqmBgb?= =?us-ascii?Q?T67ZDiSEep5I6oyPhqZIXqpIHaUmIuAnpnNi0NZ1Levg2slkdO9QwO7loA64?= =?us-ascii?Q?gwS9N8sazzqKR/TnG+z9ni0q8NN4A4A4OWYoA1LClRiyFIwlyY6dTZVa9xeT?= =?us-ascii?Q?yugQvVpct/r2Au4NKcvRguBby0NAaBw/ugMdXjiePTbHHILx2iP5C41NqZRk?= =?us-ascii?Q?n8WvF57Fxjrg09z3DjumolaMpp003KjsAa3k0OowNKRHy4lo85IxTGLzaG4Y?= =?us-ascii?Q?9amh5kRmZpafsSJjgcq18CDql0Mi7zZULX7k4PbWctwu/LvUM3btj2756VJW?= =?us-ascii?Q?HxDEjErRwSviGbv9olfV2ztsAGKJ70ZHn9R0l6T7GHqD0YciYzPzm98t0LqF?= =?us-ascii?Q?4RJkpGZBfewOfPqGIfkyuPVM4oBoeLnd3gPX5p9yTCRMHE7eAX/SL7b9ZvPM?= =?us-ascii?Q?UVdZQI005gKmcBBbHiwx+dzS/64uSSATp/b5QpKLcTOfWqNIMUEtEbSQiO+T?= =?us-ascii?Q?Hlb+Dev8W++qN7pPytUNCaJpP+U89M/PAjKCeottIOQKobRnrMeDg6fM9Uem?= =?us-ascii?Q?MTZd7Rjj3uHXneTu1YpJ/wdHf+yN8T9WVzA956fiQ0qn7pHuHTpYMGPNrbig?= =?us-ascii?Q?hs+LwmQVKA94wEl6V4kDLwxoDY2XA3AFDmpzCqjM2Rg3fr5AL2P1IHUV62Jf?= =?us-ascii?Q?LEEJ4uu6Br4RQZCSBlM6QPpZlw9QY4LtlRSBFUF58gM39vDQmOKf5FtUrk4d?= =?us-ascii?Q?h1WHmjXAKgRAgZ+UlgiQPIw24Erm+ie6RqUIVviM73WbuiSXsDViXbO0HRhb?= =?us-ascii?Q?svfJhHiadx9ZbRk7A13rYxBZjdH6edo3G6UckwSX4mIx1rMWvgBLeoKl6Zty?= =?us-ascii?Q?hTy8lU4h6O4BN3T5xyqSYN20/YS2JTqKdnVt8Ifdm2lGCdCgndx4Yzo/Rhp3?= =?us-ascii?Q?F81shJ0Fl1pcc2gm5w1bzLfBNzSje4O40tBeYq4lx1+6GCdseEibo/Uifc7X?= =?us-ascii?Q?cmKBMT6D+aZ3uWPpZQ8UC6IkgLkyrTfRN+lrELDu2mS6WANFkSocwJFJ8B8L?= =?us-ascii?Q?VtMTZ9XvpU=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0860;5:H+xZ1ETSCImCZfclphkxQ8I+T/DFhmSj+0wNk7L18tksIYqdxrveMv4EyYSbXkzfpBxD79jZYHcOwsg9XnEgRpp6304Tztvnf/WC8tl32B/r39eJzBpqBaum1nXbsYBnJ070MESZ1BDb4dIHocKw8A==;24:HLXsNQyprHHmu+apJUqVFJpjpp6ETt55yif9UTB6FbKM1/hpoY3EQS7IH1jO5eapG+SwrnRpOv9wSeWV1TIp0xLiA98LqC27qnlWPdaYqTQ=;20:caGpn8wka9qKocXiFkCzFuzIk115jHyTKAFejebpOEGTx55ubZByO5Xh/cmj3gt8v4dKrzhzZj2VEc+EWJY642a0jwGft1861cPl/vjeDVHzHJLV5huDsjUWuGxMSGwdkQYGT1GkYejSWa7PU2WVrcJNHFYJ9tqz+f2Dm8mr8YQFOjYlftc1Yj6iSqvYgegQmFQJWxMSAwDsm9vsh/zxg2ofwNCzECX4Neti+wYJT6ht2D8+WIWgfn0BAp2bT8ED SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2015 02:42:23.2363 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB0860 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: > On 10/20/2015 06:42 PM, Huang Rui wrote: > >On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > >>Hi Huang, > >> > >>[auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] > >> > >>url: https://github.com/0day-ci/linux/commits/Huang-Rui/hwmon-fam15h_power-Introduce-an-accumulated-power-reporting-algorithm/20151020-110712 > >>config: x86_64-randconfig-s2-10201413 (attached as .config) > >>reproduce: > >> # save the attached .config to linux build tree > >> make ARCH=x86_64 > >> > >>All errors (new ones prefixed by >>): > >> > >> drivers/built-in.o: In function `fam15h_power_probe': > >>>>fam15h_power.c:(.text+0x26e3a3): undefined reference to `amd_get_cores_per_cu' > >> fam15h_power.c:(.text+0x26e41e): undefined reference to `amd_get_cores_per_cu' > >> > > > >Thanks to report this issue. :) > >The root cause is that the test config doesn't enable > >CONFIG_CPU_SUP_AMD. > > > >How about below fix: > > > > Guess you don't have a choice. > Yes, if I use test config, fam15h_power isn't chosen. :) And if I use the "select" flag like below, fam15h_power can be built successfully. --- diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 796569ee..50b4fef 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -289,6 +289,7 @@ config SENSORS_K10TEMP config SENSORS_FAM15H_POWER tristate "AMD Family 15h processor power" depends on X86 && PCI + select CPU_SUP_AMD help If you say yes here you get support for processor power information of your AMD family 15h CPU. --- Thanks, Rui