From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbbJUDFF (ORCPT ); Tue, 20 Oct 2015 23:05:05 -0400 Received: from mail-bl2on0060.outbound.protection.outlook.com ([65.55.169.60]:59846 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753076AbbJUDFC (ORCPT ); Tue, 20 Oct 2015 23:05:02 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; 01.org; dkim=none (message not signed) header.d=none;01.org; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWJV88-07-50J-02 X-M-MSG: Date: Wed, 21 Oct 2015 11:04:01 +0800 From: Huang Rui To: Guenter Roeck CC: kbuild test robot , Yuanhan Liu , Fengguang Wu , , Borislav Petkov , Peter Zijlstra , Jean Delvare , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , Len Brown , "John Stultz" , =?utf-8?B?RnLvv71k77+9cmlj?= Weisbecker , , , , Andreas Herrmann , Aravind Gopalakrishnan , Borislav Petkov , Aaron Lu , Tony Li Subject: Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power Message-ID: <20151021030400.GC26968@hr-amur2> References: <1445308109-17970-6-git-send-email-ray.huang@amd.com> <201510201509.U8tGXwCz%fengguang.wu@intel.com> <20151021014214.GA26968@hr-amur2> <5626F53D.2090009@roeck-us.net> <20151021024002.GB26968@hr-amur2> <5626FD51.4090402@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5626FD51.4090402@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(2980300002)(428002)(199003)(189002)(164054003)(377454003)(24454002)(479174004)(54356999)(76176999)(50986999)(106466001)(11100500001)(5007970100001)(33716001)(105586002)(23726002)(5008740100001)(64706001)(47776003)(97756001)(110136002)(86362001)(46406003)(189998001)(19580395003)(77096005)(15975445007)(93886004)(87936001)(92566002)(46102003)(33656002)(83506001)(97736004)(5890100001)(2950100001)(5001920100001)(101416001)(4001350100001)(50466002)(107986001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0864;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0864;2:K5TnTkG2YX3LNkSMcwEE8f/DkIyqjvgfMTW/DzBFDNYb6wPsVNxy5ezmK7mDz9hYgnM3bXlAMtdOkmYdHOYot0/HzsBoB0tNsuchQQbQ302S1eLJYAaG5VmyJLsuQHBwkhvRWe4IkRcdORxtAvpdOt3WGaXRNVEtGbiYionQLvg=;3:fzRQUceggxo4htf01+bE7X8uiz0LWEdM3A89421TEAvheyOOTuBLudLV59RWiPW1tWEdb7Mg6FdiFP1dFLIAtoESBKUsrNBOvwO/Gj4E0yJB5JqPNpwRRay6BQ4k0GWq4TxX7LYdCrApsPebUUC5BkYXadAmyVIspP4eOEYnhmkXB3ByLA3f+PL1Ub/XGPznL6PU59gx9oFYJ83lTgqw5LY22CixXVE7BWedZ53vJ02tH/66kZpVvfVKe2oVlRz/;25:vrb07sINWwJZPSJqEL1gk84Fimye6UPwk/Dacy3nQnslbiJHa99qaHUO5WeRFENEoa9kGgKKBp4fjkMuszqflWUcY9pkjUXZ8+AMwHyl7kaL0XgNS7j8q16pQebOsPGGFRCe8t12NkqzmlNKHuT0GHZGU7P+v9dl9hagzsHAKJKrVwN7Srb+V1TKyJIMkWubR2CsLQ3U42VvkTZSBqhos3J61rBJC2V+W5C9TkO+YZWhxH2KvQDUID+EEJqI5t0u X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0864; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0864;20:5V8vtdrKjHoEd3O0yafGCuxph/EBkwsm0N8YfZoZI9nGnLRula+59K+r/hNxZIw2RnXTCv+sORN2m4NAUfymLrfVIixvdXAOxIIk9JYJvcR17j4UiwVxp5F0cmVKF0BmJhit3vrSyaHDa45jj5CUcCN1nV9TfC4kmrfBmJ0KYVNpX72ixxjgAF5eVBT5RrmJCynVCoKMhc6we+FKNQ7pYrXORjAoc9aMdX+B2STb5fU5LBabZuja0KdlHxsU/R2IPglZQlQJGnSK6f0Nub7uhK5gnq2yb97+uKtL+PTYWGua7/6WPgxv/iSYY6cjXw/q+x78jaap9FEj7dRoiNlYHtNuDEKokRKil6PwX8fxv4cK9rBZAcyLS+r5rBTJFnW01LFyjfFih/KfcUA4GeLCbSYnQ6fZAQSlOjOrf/mACc2CXj0GLH0QHbnhlavuQ0YF0hOqGizWcIIetfhckZbtvaa/zdBuYuFC2plls2V9OA2cTzryOpKSnrXBZZ9ofUVA;4:g5A5yRyAhuZ5FLRuEj5j41IhHwHm3H/hscf7XZQqwSUai/u4cIljrDt2Ek1+wsWnNWBP4+mC2gbuMO6dNFp87RIiZ7jTAi0aMdaZVCw0zix7MMiXkCL07IOn7vJF+mHEnH+hd3ySAwoO3/Gg94y6ygi3GYk+yLQODDbXNmxYlg+l8825WPmY9bsSXGvzdhIQc2q4s1w6QECdB0F7rvhFWmlh0f3YjxqbiT03drE+s9xMlwEVFDqNC0oVZ1zEEeFFu1YiUwREizW+JOTpaTdIbxl6TWFoSehh5EgvjdK5aqOCMTv+vSnbkIg794S82feB9m/YGv/v6IwNZkgDiwV+4W1eFYEujmSwYSgFYXvgyBQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:SN1PR12MB0864;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0864; X-Forefront-PRVS: 073631BD3D X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR12MB0864;23:GabgCf9tJg0xwrRhS/OPEwOLqBYV/UZwoXeXqBtw7?= =?us-ascii?Q?IbJLBIMIY6E0IKsTQQJ3fC4uIeyTGfilmLJdIcqc9nGwxHZkKEVHuLzatNP+?= =?us-ascii?Q?W+sP2Fq7+51etCHvmo4XfZPOkITRV7GfxvWmjSQxALOueETLZaadyxXbEZro?= =?us-ascii?Q?RW/2IFs+g2zZZnLcrJCsNP8Z7zbHitEN7jAZVo/fd5/bYZiVDxuuQGxKNn21?= =?us-ascii?Q?buu4QpDAE0VqRkL05XifF1MC3ZLA8a6fZPX1QRtnFg7nq1kH3JRTQnRt5iKH?= =?us-ascii?Q?mGI6DVKutiEzpLqlTf1sZc12rNNoQkEtcaP9l+Tyfdh27EO7tL75PvnP3iYH?= =?us-ascii?Q?aqtH1j9xUfggcNQr7HShpKpaJR06QZ3iYHBoi87viYiiae6WLb4XhVLZBPfb?= =?us-ascii?Q?kts3VTUl9JE/nhZNtqg6r7m3+4gHjlDKa0+dAK94VgBqBmcZgYIWk6wz90Yu?= =?us-ascii?Q?qTmcfkczhlk0g4divYDvDFyHi3bYAiLHD6u5YgtdFCXILe+awD7RZLBrz4S8?= =?us-ascii?Q?5eSihA3FLn32n0FGA8HKnhmbO1EnFyUC1Pkvd4a9J36+oq+mQoBjLJ5fzBiN?= =?us-ascii?Q?a132KYoiHMnWb9kH4igPKlw9TWxjrM51ZA5tWcJUxLjKuDZqzlIBrISljzIy?= =?us-ascii?Q?jMGD5mnyEN5BFLsJ9eYgFGhpXK7sdgJNm9EYuKwApuc7K3diM+/aDvCK/3sw?= =?us-ascii?Q?g0x7B7Yzy7yVjbHBD9+exrmUoRbxe9C/kAwfXSk+T0mAu+ggBCFz6L08ZOQE?= =?us-ascii?Q?x0SzrcH/f3GAqPEX+t6Fpw5asBfw7uqnFbzuf9BogZ+V+YJC76d6jJzzGa2F?= =?us-ascii?Q?n/K6XonNLyPvwYr+XMNO/RYLjOC4T3442jZA1moGnq9ruwKbqzxlq8z/TWMM?= =?us-ascii?Q?XPUrVssbyllLwrGJXtopyeIF6WhYuW/copQ0XugGn8lazxx3pJ23yCQ+BS9V?= =?us-ascii?Q?626thGhOtI7KV0xexcungajd8B14YA5DDSSyrYXZ6BHNdxF/SjOtxmanJ+eL?= =?us-ascii?Q?RC8wnexRvv0uz5e/64PqdiwigocbYav3MS6dBg/8jVmvgfI9jwr2IbkWGKDh?= =?us-ascii?Q?XsCd6pPzJZAcZ+L7ye+/pNC/10/nQL7K768Y35xw3icGh9qCVkyEqrr0ZoAG?= =?us-ascii?Q?gvuPhrxOpq6umds/z/eQ6Rjms1pkaDIOWWIUDctTrXn+9g0tzFg/e4mu0PiV?= =?us-ascii?Q?7aUtTVsR+BNC3+e6SiDg4H/wGJF7LD+fEyhY1o2UJ1ae8utJZqvNt/2zxPb8?= =?us-ascii?Q?yoRoCl7xzkZsPhafYE=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0864;5:e3TfYP1mGp5Q2hhrSmPzN85+Us4KUxOkkZGfV+7gGXRairV4lIXMN8N3eR5ByqcAvGeiQBkhIClULSLKo9eulvWwaMvMS+5KwZPG1Gm/bE4EWQ5uiXIJB545ZVCxognFZDwH5oRTh6daSoONbFwgaw==;24:VXcwKYQ8o2FfFnh+EMTbBi12ZA/HSVeU0bO2O14jP1rf4LTpBwC/ddLjRjuJw2VZmt00fYoYxTdgTouRpbB/rd325oIqjXb8yI6XjQ2VM+s=;20:WZbouzRbPhPxONP2VabwtRUcFsloXpI4AzoV4xQpkyaon80dTulOsFsuzl6tkTRX/Tc1MSJ0jZhRtUx4nyPWRkZlYSARPhUHabgU7QoUyc1ONQquQHBQfawzeWZzvlIeOv/xDFnmaVKxvcSfhhARHZTwh0QpLMd0nMO9pa9xhSFwKhFmkTyNLmrZyT/hKbuLVdnbG1kBEJunVuAJSpukkQhc3IyN6eufGq10SAe3VtbPOxrnEFC0nXFNZ8mj8IDk SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2015 03:04:57.0253 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0864 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > On 10/20/2015 07:40 PM, Huang Rui wrote: > >On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: > >>On 10/20/2015 06:42 PM, Huang Rui wrote: > >>>On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > >>>>Hi Huang, > >>>> > >>>>[auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] > >>>> > >>>>url: https://github.com/0day-ci/linux/commits/Huang-Rui/hwmon-fam15h_power-Introduce-an-accumulated-power-reporting-algorithm/20151020-110712 > >>>>config: x86_64-randconfig-s2-10201413 (attached as .config) > >>>>reproduce: > >>>> # save the attached .config to linux build tree > >>>> make ARCH=x86_64 > >>>> > >>>>All errors (new ones prefixed by >>): > >>>> > >>>> drivers/built-in.o: In function `fam15h_power_probe': > >>>>>>fam15h_power.c:(.text+0x26e3a3): undefined reference to `amd_get_cores_per_cu' > >>>> fam15h_power.c:(.text+0x26e41e): undefined reference to `amd_get_cores_per_cu' > >>>> > >>> > >>>Thanks to report this issue. :) > >>>The root cause is that the test config doesn't enable > >>>CONFIG_CPU_SUP_AMD. > >>> > >>>How about below fix: > >>> > >> > >>Guess you don't have a choice. > >> > > > >Yes, if I use test config, fam15h_power isn't chosen. :) > > > >And if I use the "select" flag like below, fam15h_power can be built > >successfully. > > > That is another possibility, though that isn't how CPU_SUP_AMD > is handled by its other users. Matter of philosophy, I guess. > Err, sorry. Could you please point out the other possibility? Thanks, Rui