From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753399AbbJUGF3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 21 Oct 2015 02:05:29 -0400
Received: from mx2.suse.de ([195.135.220.15]:52846 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753091AbbJUGF1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 21 Oct 2015 02:05:27 -0400
Date: Wed, 21 Oct 2015 08:05:20 +0200
From: Jean Delvare <jdelvare@suse.de>
To: Huang Rui <ray.huang@amd.com>
Cc: Guenter Roeck <linux@roeck-us.net>, kbuild test robot <lkp@intel.com>,
        Yuanhan Liu <yuanhan.liu@linux.intel.com>,
        Fengguang Wu <fengguang.wu@intel.com>, <kbuild-all@01.org>,
        Borislav Petkov <bp@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Andreas Herrmann <herrmann.der.user@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        "John Stultz" <john.stultz@linaro.org>,
        Frederic Weisbecker <fweisbec@gmail.com>, <lm-sensors@lm-sensors.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Andreas Herrmann <herrmann.der.user@googlemail.com>,
        Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
        Borislav Petkov <bp@alien8.de>, Aaron Lu <aaron.lu@intel.com>,
        Tony Li <tony.li@amd.com>
Subject: Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit
 accumulated power
Message-ID: <20151021080520.30f28ce9@endymion.delvare>
In-Reply-To: <20151021030400.GC26968@hr-amur2>
References: <1445308109-17970-6-git-send-email-ray.huang@amd.com>
	<201510201509.U8tGXwCz%fengguang.wu@intel.com>
	<20151021014214.GA26968@hr-amur2>
	<5626F53D.2090009@roeck-us.net>
	<20151021024002.GB26968@hr-amur2>
	<5626FD51.4090402@roeck-us.net>
	<20151021030400.GC26968@hr-amur2>
Organization: SUSE Linux
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rui,

On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote:
> On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote:
> > On 10/20/2015 07:40 PM, Huang Rui wrote:
> > >>>Thanks to report this issue. :)
> > >>>The root cause is that the test config doesn't enable
> > >>>CONFIG_CPU_SUP_AMD.
> > >>>
> > >>>How about below fix:
> > >>>
> > >>
> > >>Guess you don't have a choice.
> > >>
> > >
> > >Yes, if I use test config, fam15h_power isn't chosen. :)
> > >
> > >And if I use the "select" flag like below, fam15h_power can be built
> > >successfully.
> > >
> > That is another possibility, though that isn't how CPU_SUP_AMD
> > is handled by its other users. Matter of philosophy, I guess.
> 
> Err, sorry. Could you please point out the other possibility?

Both possibilities came from you. First one is to use "depends", second
one is to use "select".

As pointed out bu Gunter, other drivers (EDAC_DECODE_MCE, MICROCODE,
AMD_NB) use "depends" so you should do the same for consistency.

-- 
Jean Delvare
SUSE L3 Support