From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbbJUJZe (ORCPT ); Wed, 21 Oct 2015 05:25:34 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:34314 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754007AbbJUJZb (ORCPT ); Wed, 21 Oct 2015 05:25:31 -0400 Date: Wed, 21 Oct 2015 11:25:25 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Andi Kleen , Jiri Olsa , Arnaldo Carvalho de Melo Subject: Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv Message-ID: <20151021092524.GA9765@gmail.com> References: <1445372707-18744-1-git-send-email-acme@kernel.org> <1445372707-18744-5-git-send-email-acme@kernel.org> <20151021083215.GE2881@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151021083215.GE2881@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Tue, Oct 20, 2015 at 05:25:07PM -0300, Arnaldo Carvalho de Melo wrote: > > From: Andi Kleen > > > > Add a missing field to the perf_event_attr debug output. > > > > Signed-off-by: Andi Kleen > > Cc: Jiri Olsa > > Cc: Peter Zijlstra > > Link: http://lkml.kernel.org/r/1445366797-30894-4-git-send-email-andi@firstfloor.org > > Signed-off-by: Arnaldo Carvalho de Melo > > --- > > tools/perf/util/evsel.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > > index 8be867ccefe9..11bf3f2c51cd 100644 > > --- a/tools/perf/util/evsel.c > > +++ b/tools/perf/util/evsel.c > > @@ -1229,6 +1229,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr, > > PRINT_ATTRf(config, p_hex); > > PRINT_ATTRn("{ sample_period, sample_freq }", sample_period, p_unsigned); > > PRINT_ATTRf(sample_type, p_sample_type); > > + PRINT_ATTRf(branch_sample_type, p_unsigned); > > PRINT_ATTRf(read_format, p_read_format); > > As said in the original thread, this is the wrong place, it should be > between config2 and sample_regs_user. Ok, I've unpulled these updates, since I haven't pushed these bits out yet. Thanks, Ingo