From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv
Date: Wed, 21 Oct 2015 10:22:17 -0300 [thread overview]
Message-ID: <20151021132217.GE10639@kernel.org> (raw)
In-Reply-To: <20151021092524.GA9765@gmail.com>
Em Wed, Oct 21, 2015 at 11:25:25AM +0200, Ingo Molnar escreveu:
> * Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, Oct 20, 2015 at 05:25:07PM -0300, Arnaldo Carvalho de Melo wrote:
> > > From: Andi Kleen <ak@linux.intel.com>
> > > Add a missing field to the perf_event_attr debug output.
> > > +++ b/tools/perf/util/evsel.c
> > > @@ -1229,6 +1229,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> > > PRINT_ATTRf(config, p_hex);
> > > PRINT_ATTRn("{ sample_period, sample_freq }", sample_period, p_unsigned);
> > > PRINT_ATTRf(sample_type, p_sample_type);
> > > + PRINT_ATTRf(branch_sample_type, p_unsigned);
> > > PRINT_ATTRf(read_format, p_read_format);
> > As said in the original thread, this is the wrong place, it should be
> > between config2 and sample_regs_user.
> Ok, I've unpulled these updates, since I haven't pushed these bits out yet.
I'll fix this as pointed out by Peter and resubmit.
- Arnaldo
next prev parent reply other threads:[~2015-10-21 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 20:25 [GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-10-20 20:25 ` [PATCH 1/4] perf build: Add fixdep to .gitignore Arnaldo Carvalho de Melo
2015-10-20 20:25 ` [PATCH 2/4] tools lib traceevent: update KVM plugin Arnaldo Carvalho de Melo
2015-10-20 20:25 ` [PATCH 3/4] perf cpu_map: Fix core dump caused by per-socket/core system-wide stat Arnaldo Carvalho de Melo
2015-10-20 20:25 ` [PATCH 4/4] perf evsel: Print branch filter state with -vv Arnaldo Carvalho de Melo
2015-10-21 8:32 ` Peter Zijlstra
2015-10-21 9:25 ` Ingo Molnar
2015-10-21 13:22 ` Arnaldo Carvalho de Melo [this message]
2015-10-21 18:07 ` Arnaldo Carvalho de Melo
2015-10-21 19:02 ` Peter Zijlstra
2015-10-21 8:11 ` [GIT PULL 0/4] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021132217.GE10639@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).