From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755093AbbJUNWW (ORCPT ); Wed, 21 Oct 2015 09:22:22 -0400 Received: from mail.kernel.org ([198.145.29.136]:49510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbJUNWV (ORCPT ); Wed, 21 Oct 2015 09:22:21 -0400 Date: Wed, 21 Oct 2015 10:22:17 -0300 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, Andi Kleen , Jiri Olsa Subject: Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv Message-ID: <20151021132217.GE10639@kernel.org> References: <1445372707-18744-1-git-send-email-acme@kernel.org> <1445372707-18744-5-git-send-email-acme@kernel.org> <20151021083215.GE2881@worktop.programming.kicks-ass.net> <20151021092524.GA9765@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151021092524.GA9765@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 21, 2015 at 11:25:25AM +0200, Ingo Molnar escreveu: > * Peter Zijlstra wrote: > > On Tue, Oct 20, 2015 at 05:25:07PM -0300, Arnaldo Carvalho de Melo wrote: > > > From: Andi Kleen > > > Add a missing field to the perf_event_attr debug output. > > > +++ b/tools/perf/util/evsel.c > > > @@ -1229,6 +1229,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr, > > > PRINT_ATTRf(config, p_hex); > > > PRINT_ATTRn("{ sample_period, sample_freq }", sample_period, p_unsigned); > > > PRINT_ATTRf(sample_type, p_sample_type); > > > + PRINT_ATTRf(branch_sample_type, p_unsigned); > > > PRINT_ATTRf(read_format, p_read_format); > > As said in the original thread, this is the wrong place, it should be > > between config2 and sample_regs_user. > Ok, I've unpulled these updates, since I haven't pushed these bits out yet. I'll fix this as pointed out by Peter and resubmit. - Arnaldo