From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755248AbbJUP1H (ORCPT ); Wed, 21 Oct 2015 11:27:07 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:38053 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753435AbbJUP1E (ORCPT ); Wed, 21 Oct 2015 11:27:04 -0400 Date: Wed, 21 Oct 2015 16:26:59 +0100 From: Lee Jones To: Mark Brown Cc: "Andrew F. Davis" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alexandre Courbot , Grygorii Strashko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] Documentation: tps65086: Add DT bindings for the TPS65086 PMIC Message-ID: <20151021152659.GF3270@x1> References: <20151019091311.GH31804@x1> <5625095F.5080204@ti.com> <20151019152100.GK31804@x1> <56250AF9.3030907@ti.com> <20151020113128.GN31804@x1> <56264990.8050501@ti.com> <20151021084633.GB3270@x1> <20151021102952.GJ32054@sirena.org.uk> <20151021111832.GC3270@x1> <20151021121409.GA8232@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151021121409.GA8232@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Oct 2015, Mark Brown wrote: > On Wed, Oct 21, 2015 at 12:18:32PM +0100, Lee Jones wrote: > > On Wed, 21 Oct 2015, Mark Brown wrote: > > > On Wed, Oct 21, 2015 at 09:46:33AM +0100, Lee Jones wrote: > > > > On Tue, 20 Oct 2015, Andrew F. Davis wrote: > > > > It is however the normal way we write compatible strings - the class > > > information would normaly go in the node name (ie, i2c@7000c000 or > > > whatever). > > > I didn't say it hasn't been done before, just that I didn't like it > > for the aforementioned reasons. I can also find 1000's of compatible > > strings which do append "-", so it's not exactly an > > unheard of practice. > > It's a pretty substantial change in the way we make compatible strings > that we probably want to discuss more widely if we want to adopt it - > we've not been using that idiom and it's pretty surprising. I'm not > really sure it help much and we do already have the pre-@ noise words > for this purpose (as well as comments in the DT). I'm not *that* fussed about it to justify starting-up wider community discussions. My only point is that: compatible = ",udw9283"; ... is meaningless gibberish and I think it'd be better to be more forthcoming which prevents having to dig around in DTS files for the node name/label for true device/type identification. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog