linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86, perf: Use INST_RETIRED.PREC_DIST for cycles:pp on Skylake
Date: Wed, 21 Oct 2015 18:52:52 +0200	[thread overview]
Message-ID: <20151021165252.GJ3604@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151021152608.GG15102@tassilo.jf.intel.com>

On Wed, Oct 21, 2015 at 08:26:08AM -0700, Andi Kleen wrote:
> So it turns out that UOPS_RETIRED.ALL+pebs only works by accident
> on Skylake. It's not in the specification.

Accident or not, it works and you've tested it. Might as well keep it.
Specs can be updated.

Also, even with the SNB 'hickup' they still haven't got the memo that
cycles is important for PEBS ?

  reply	other threads:[~2015-10-21 16:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 22:58 [PATCH] x86, perf: Use INST_RETIRED.PREC_DIST for cycles:pp on Skylake Andi Kleen
2015-10-20 11:36 ` Peter Zijlstra
2015-10-20 22:28   ` Andi Kleen
2015-10-21  8:09     ` Peter Zijlstra
2015-10-21 15:26       ` Andi Kleen
2015-10-21 16:52         ` Peter Zijlstra [this message]
2015-10-21 16:55           ` Andi Kleen
2015-10-21 18:57             ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151021165252.GJ3604@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).