From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754340AbbJVAH5 (ORCPT ); Wed, 21 Oct 2015 20:07:57 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:35907 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbbJVAH4 (ORCPT ); Wed, 21 Oct 2015 20:07:56 -0400 Date: Thu, 22 Oct 2015 09:07:56 +0900 From: Minchan Kim To: Guenter Roeck Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: Fix build on non-MMU systems Message-ID: <20151022000756.GE23631@bbox> References: <1445436023-13028-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1445436023-13028-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Andrew already had a fix. Thanks for the report! On Wed, Oct 21, 2015 at 07:00:23AM -0700, Guenter Roeck wrote: > Non-MMU systems fail to build with > > In file included from init/main.c:50:0: > include/linux/rmap.h:274:1: error: > expected declaration specifiers or ‘...’ before ‘{’ token > > Fixes: c3f568752340 ("mm: support madvise(MADV_FREE)") > Cc: Minchan Kim > Signed-off-by: Guenter Roeck > --- > include/linux/rmap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index 978f65066fd5..853f4f3c6742 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -270,7 +270,7 @@ int rmap_walk(struct page *page, struct rmap_walk_control *rwc); > > static inline int page_referenced(struct page *page, int is_locked, > struct mem_cgroup *memcg, > - unsigned long *vm_flags, > + unsigned long *vm_flags) > { > *vm_flags = 0; > return 0; > -- > 2.1.4 >