From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756849AbbJVIDL (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Oct 2015 04:03:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58220 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755346AbbJVICi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Oct 2015 04:02:38 -0400
Date: Thu, 22 Oct 2015 10:01:46 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "Liang, Kan" <kan.liang@intel.com>
Subject: Re: [PATCH 19/57] perf tools: Add attr_update event
Message-ID: <20151022080146.GB29953@krava.redhat.com>
References: <1444992092-17897-1-git-send-email-jolsa@kernel.org>
 <1444992092-17897-20-git-send-email-jolsa@kernel.org>
 <20151019210004.GF3215@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151019210004.GF3215@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 19, 2015 at 06:00:04PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Oct 16, 2015 at 12:40:54PM +0200, Jiri Olsa escreveu:
> > It'll server as base event for additional event attributes
> > details, that are not part of the attr event.
> > 
> > At the moment this event is just dummy one without specific
> > functionality. The type value will distinguish the update
> > event details. It comes in following patches.
> > 
> > The idea for this event is to be extensible for any update
> > that attr event might need in the future.
> 
> "Update"? Found it confusing, how about calling it "add event
> attribute", because that is what this is doing, adding attributes, like
> "unit" (Joules, MiB, nsec, etc), "scale", etc.

well, we have PERF_RECORD_HEADER_ATTR event based on which the
event is created.. so PERF_RECORD_HEADER_ATTR_UPDATE seemed
like good choice.. anyway, how about:

  PERF_RECORD_ADD_EVENT_ATTR
  PERF_RECORD_EVENT_ATTR
  PERF_RECORD_EVENT_UPDATE

jirka