From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756975AbbJVIkm (ORCPT ); Thu, 22 Oct 2015 04:40:42 -0400 Received: from verein.lst.de ([213.95.11.211]:38658 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756907AbbJVIkh (ORCPT ); Thu, 22 Oct 2015 04:40:37 -0400 Date: Thu, 22 Oct 2015 10:40:34 +0200 From: Christoph Hellwig To: Daniel Baluta Cc: jic23@kernel.org, jlbec@evilplan.org, linux-iio@vger.kernel.org, linux-fsdevel@vger.kernel.org, lars@metafoo.de, knaack.h@gmx.de, linux-kernel@vger.kernel.org, octavian.purdila@intel.com, pebolle@tiscali.nl, patrick.porlan@intel.com, adriana.reus@intel.com, constantin.musca@intel.com, marten@intuitiveaerial.com, cristina.opriceana@gmail.com, pmeerw@pmeerw.net, hch@lst.de, viro@zeniv.linux.org.uk, akpm@linux-foundation.org Subject: Re: [PATCH v8 1/5] configfs: Allow dynamic group creation Message-ID: <20151022084034.GA21923@lst.de> References: <1445338426-4126-1-git-send-email-daniel.baluta@intel.com> <1445338426-4126-2-git-send-email-daniel.baluta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445338426-4126-2-git-send-email-daniel.baluta@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote: > We don't want to hardcode default groups at subsystem > creation time. We export: > * configfs_register_group > * configfs_unregister_group > to allow drivers to programatically create/destroy groups > later, after module init time. > > This is needed for IIO configfs support. This looks like a good start, and maybe we should merge it as is given that merge window is about to end. But I have two requests, one trivial and one not so: a) please provide kerneldoc comments for the new functions b) just pass the name and item type and dynamically allocate the actua group. With that we can avoid a lot of boilerplate code and could also replace the horrible static sized defaults_groups array in current users with your new function.