From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965124AbbJVJcr (ORCPT ); Thu, 22 Oct 2015 05:32:47 -0400 Received: from mail.skyhub.de ([78.46.96.112]:36062 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932627AbbJVJco (ORCPT ); Thu, 22 Oct 2015 05:32:44 -0400 Date: Thu, 22 Oct 2015 11:32:42 +0200 From: Borislav Petkov To: Tan Xiaojun Cc: dougthompson@xmission.com, mchehab@osg.samsung.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH for-next] EDAC: fix misuse of PAGES_TO_MiB macros Message-ID: <20151022093242.GB3671@pd.tnic> References: <1445341538-24271-1-git-send-email-tanxiaojun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1445341538-24271-1-git-send-email-tanxiaojun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 07:45:38PM +0800, Tan Xiaojun wrote: > The PAGES_TO_MiB macros is only used for unit conversion. > > Signed-off-by: Tan Xiaojun > --- > drivers/edac/edac_mc.c | 2 +- > drivers/edac/ghes_edac.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c > index 943ed8c..77ecd6a 100644 > --- a/drivers/edac/edac_mc.c > +++ b/drivers/edac/edac_mc.c > @@ -1302,7 +1302,7 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type, > grain_bits = fls_long(e->grain) + 1; > trace_mc_event(type, e->msg, e->label, e->error_count, > mci->mc_idx, e->top_layer, e->mid_layer, e->low_layer, > - PAGES_TO_MiB(e->page_frame_number) | e->offset_in_page, > + (e->page_frame_number << PAGE_SHIFT) | e->offset_in_page, > grain_bits, e->syndrome, e->other_detail); > > edac_raw_mc_handle_error(type, mci, e); > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c > index b1e4512..e3fa439 100644 > --- a/drivers/edac/ghes_edac.c > +++ b/drivers/edac/ghes_edac.c > @@ -397,7 +397,7 @@ void ghes_edac_report_mem_error(struct ghes *ghes, int sev, > "APEI location: %s %s", e->location, e->other_detail); > trace_mc_event(type, e->msg, e->label, e->error_count, > mci->mc_idx, e->top_layer, e->mid_layer, e->low_layer, > - PAGES_TO_MiB(e->page_frame_number) | e->offset_in_page, > + (e->page_frame_number << PAGE_SHIFT) | e->offset_in_page, > grain_bits, e->syndrome, pvt->detail_location); > > /* Report the error via EDAC API */ > -- Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.