From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757264AbbJVLYa (ORCPT ); Thu, 22 Oct 2015 07:24:30 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:36586 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755460AbbJVLY3 (ORCPT ); Thu, 22 Oct 2015 07:24:29 -0400 X-AuditID: 85900ec0-9afc5b9000001a57-5a-5628c623c3c6 Subject: Re: [PATCH 00/26] tracing: 'hist' triggers From: Masami Hiramatsu To: Tom Zanussi Cc: andi@firstfloor.org, josh@joshtriplett.org, peterz@infradead.org, daniel.wagner@bmw-carit.de, linux-kernel@vger.kernel.org, Steven Rostedt , Shuah Khan , Ingo Molnar , mathieu.desnoyers@efficios.com, Namhyung Kim Date: Thu, 22 Oct 2015 20:17:27 +0900 Message-ID: <20151022111727.9135.4711.stgit@localhost.localdomain> In-Reply-To: References: User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tom, I've tested your series of the hist trigger v10 with these testcases included in the couple of patches, which tests following features. - traceon-traceoff trigger - enable/disable_event trigger - snapshot trigger - stacktrace trigger - trigger filters - Histogram trigger itself - Histogram with string key - Histogram with compound keys - Histogram with sort key - Histogram trigger modifiers (execname, hex, syscall) - Multiple histograms on an event - Named histogram - Named histogram on multi events Here is the test result. ---- # ./ftracetest test.d/trigger/ === Ftrace unit tests === [1] event trigger - test event enable/disable trigger [PASS] [2] event trigger - test trigger filter [PASS] [3] event trigger - test histogram modifiers [PASS] [4] event trigger - test histogram trigger [PASS] [5] event trigger - test multiple histogram triggers [PASS] [6] event trigger - test snapshot-trigger [PASS] [7] event trigger - test stacktrace-trigger [PASS] [8] event trigger - test traceon/off trigger [PASS] # of passed: 8 # of failed: 0 # of unresolved: 0 # of untested: 0 # of unsupported: 0 # of xfailed: 0 # of undefined(test bug): 0 ---- So I'm OK for your hist trigger series. If you would not mind, please include these patches and my tested-by in your series to prove your series is good :) Tested-by: Masami Hiramatsu Thank you, --- Masami Hiramatsu (2): kselftests/ftrace : Add event trigger testcases kselftests/ftrace: Add hist trigger testcases tools/testing/selftests/ftrace/test.d/functions | 9 ++ .../ftrace/test.d/trigger/trigger-eventonoff.tc | 64 +++++++++++++++ .../ftrace/test.d/trigger/trigger-filter.tc | 59 ++++++++++++++ .../ftrace/test.d/trigger/trigger-hist-mod.tc | 65 ++++++++++++++++ .../ftrace/test.d/trigger/trigger-hist.tc | 83 ++++++++++++++++++++ .../ftrace/test.d/trigger/trigger-multihist.tc | 73 ++++++++++++++++++ .../ftrace/test.d/trigger/trigger-snapshot.tc | 56 +++++++++++++ .../ftrace/test.d/trigger/trigger-stacktrace.tc | 53 +++++++++++++ .../ftrace/test.d/trigger/trigger-traceonoff.tc | 58 ++++++++++++++ 9 files changed, 520 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-eventonoff.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-filter.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-multihist.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-snapshot.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-stacktrace.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-traceonoff.tc -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com