public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 0/2] [GIT PULL] tracing: Fix RCU warnings in stack tracer
Date: Thu, 22 Oct 2015 09:20:44 -0400	[thread overview]
Message-ID: <20151022132044.002031045@goodmis.org> (raw)


Linus,

Running tests on other changes, the system locked up due to lots
of warnings. It was caused by the stack tracer triggering a warning
about using rcu_dereference() when RCU was not watching. This can happen
due to the fact that the stack tracer uses the function tracer to check
each function, and there's functions that may be called and traced
when RCU stopped watching. Namely when a function is called just before
going idle or to userspace and after RCU stopped watching that current
CPU.

The first patch makes sure that RCU is watching when the stack tracer
uses RCU. The second patch is to make sure that the stack tracer does
not get called by functions in NMI, as it's not NMI safe.

Please pull the latest trace-fixes-v4.3-rc6 tree, which can be found at:


  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
trace-fixes-v4.3-rc6

Tag SHA1: 520ef22047724f1fae143e504b4da9737e50d32c
Head SHA1: 1904be1b6bb92058c8e00063dd59df2df294e258


Steven Rostedt (Red Hat) (2):
      tracing: Have stack tracer force RCU to be watching
      tracing: Do not allow stack_tracer to record stack in NMI

----
 kernel/trace/trace_stack.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

             reply	other threads:[~2015-10-22 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 13:20 Steven Rostedt [this message]
2015-10-22 13:20 ` [PATCH 1/2] tracing: Have stack tracer force RCU to be watching Steven Rostedt
2015-10-29  9:54   ` Paul E. McKenney
2015-10-22 13:20 ` [PATCH 2/2] tracing: Do not allow stack_tracer to record stack in NMI Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151022132044.002031045@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox