From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Borislav Petkov <bp@suse.de>,
Chandler Carruth <chandlerc@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled
Date: Thu, 22 Oct 2015 11:03:07 -0300 [thread overview]
Message-ID: <20151022140307.GG32514@kernel.org> (raw)
In-Reply-To: <CAE40pdfbyCsN90q+WG5R46AS_6OkYFAx9CAam1-AXOhoCMbCLQ@mail.gmail.com>
Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu:
> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> > Hi Ingo,
> >
> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >>
> >> * Namhyung Kim <namhyung@kernel.org> wrote:
> >>
> >>> The caller callchain order is useful with --children option since it can
> >>> show 'overview' style output, but other commands which don't use
> >>> --children feature like 'perf script' or even 'perf report/top' without
> >>> --children are better to keep caller order.
> >
> > Oops, there's a typo: s/caller order/callee order/ :)
>
> Thanks, I was wondering about that (and I've made that typo myself).
> Thanks for the patch!
Brendan, can I take that as an Acked-by?
> Brendan
next prev parent reply other threads:[~2015-10-22 14:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 6:28 [PATCH 1/3] perf tools: Move callchain help messages to callchain.h Namhyung Kim
2015-10-22 6:28 ` [PATCH 2/3] perf top: Support call-graph display options also Namhyung Kim
2015-10-22 8:23 ` Ingo Molnar
2015-10-22 12:20 ` Namhyung Kim
2015-10-22 13:57 ` Taeung Song
2015-10-22 14:34 ` Namhyung Kim
2015-10-22 18:38 ` Arnaldo Carvalho de Melo
2015-10-23 8:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-22 6:28 ` [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled Namhyung Kim
2015-10-22 7:32 ` Ingo Molnar
2015-10-22 7:38 ` Namhyung Kim
2015-10-22 9:49 ` Brendan Gregg
2015-10-22 14:03 ` Arnaldo Carvalho de Melo [this message]
2015-11-02 23:59 ` Brendan Gregg
2015-10-22 12:21 ` Frederic Weisbecker
2015-10-22 7:45 ` [RFC/PATCH RESEND " Namhyung Kim
2015-10-22 18:38 ` Arnaldo Carvalho de Melo
2015-10-23 8:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-22 12:19 ` [RFC/PATCH 3/3] " Frederic Weisbecker
2015-10-22 14:13 ` Arnaldo Carvalho de Melo
2015-10-22 14:22 ` Namhyung Kim
2015-10-22 14:37 ` Arnaldo Carvalho de Melo
2015-10-22 15:51 ` Namhyung Kim
2015-10-22 16:21 ` Arnaldo Carvalho de Melo
2015-10-22 8:02 ` [PATCH 1/3] perf tools: Move callchain help messages to callchain.h Ingo Molnar
2015-10-22 12:13 ` Namhyung Kim
2015-10-22 14:17 ` Arnaldo Carvalho de Melo
2015-10-23 9:59 ` Ingo Molnar
2015-10-23 14:27 ` Arnaldo Carvalho de Melo
2015-10-23 16:40 ` Arnaldo Carvalho de Melo
2015-10-22 18:38 ` Arnaldo Carvalho de Melo
2015-10-23 8:30 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022140307.GG32514@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=bp@suse.de \
--cc=brendan.d.gregg@gmail.com \
--cc=chandlerc@gmail.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).