From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757582AbbJVNTW (ORCPT ); Thu, 22 Oct 2015 09:19:22 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:39880 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756968AbbJVNTU (ORCPT ); Thu, 22 Oct 2015 09:19:20 -0400 X-Greylist: delayed 671 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Oct 2015 09:19:19 EDT X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Thu, 22 Oct 2015 15:07:50 +0200 From: Stefan Richter To: Arnd Bergmann Cc: outreachy-kernel@googlegroups.com, Amitoj Kaur Chawla , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH v2] firewire: Replace timeval with timespec64 Message-ID: <20151022150750.37602576@kant> In-Reply-To: <7551827.VsyUKdOpMQ@wuerfel> References: <20151021223500.GA26701@amitoj-Inspiron-3542> <7551827.VsyUKdOpMQ@wuerfel> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 22 Arnd Bergmann wrote: > On Thursday 22 October 2015 04:05:00 Amitoj Kaur Chawla wrote: [...] > Reviewed-by: Arnd Bergmann > > (adding the y2038 mailing list as well) > > > Changes in v2: > > -Replaced timespec with timspec64 > > -Modified commit message > > -Used ktime_get_real_ts64() instead of getnstimeofday64() [...] > > --- a/drivers/firewire/nosy.c > > +++ b/drivers/firewire/nosy.c [...] > > @@ -413,17 +414,18 @@ static void > > packet_irq_handler(struct pcilynx *lynx) [...] > > - do_gettimeofday(&tv); > > - lynx->rcv_buffer[0] = (__force __le32)tv.tv_usec; > > + ktime_get_real_ts64(&ts64); > > + timestamp = ts64.tv_nsec / NSEC_PER_USEC; > > + lynx->rcv_buffer[0] = (__force __le32)timestamp; Looks fine to me, but I have a question. It was possibly already discussed at patch v1, though that was apparently not posted to an open list. include/linux/timekeeping.h says: #define ktime_get_real_ts64(ts) getnstimeofday64(ts) kernel/time/timekeeping.c says: /** * do_gettimeofday - Returns the time of day in a timeval * @tv: pointer to the timeval to be set * * NOTE: Users should be converted to using getnstimeofday() */ So what is the reason for calling ktime_get_real_ts64() instead of getnstimeofday[64]()? PS, note to self: Independently of this patch, I need to check whether CLOCK_REALTIME was really the right clock here, in contrast to CLOCK_MONOTONIC. -- Stefan Richter -=====-===== =-=- =-==- http://arcgraph.de/sr/