From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965368AbbJVQ0d (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Oct 2015 12:26:33 -0400
Received: from mail.kernel.org ([198.145.29.136]:42338 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S965066AbbJVQ0c (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Oct 2015 12:26:32 -0400
Date: Thu, 22 Oct 2015 13:26:28 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Chandler Carruth <chandlerc@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/2] perf tools: Improve call graph documents and help
 messages
Message-ID: <20151022162628.GI2455@kernel.org>
References: <1445524112-5201-1-git-send-email-namhyung@kernel.org>
 <1445524112-5201-2-git-send-email-namhyung@kernel.org>
 <20151022144639.GF2455@kernel.org>
 <CAM9d7cjmVKpyPRnX=Qv4k7q1a_z21iOi_y1xOe05FYzT5QyGwQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7cjmVKpyPRnX=Qv4k7q1a_z21iOi_y1xOe05FYzT5QyGwQ@mail.gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Fri, Oct 23, 2015 at 01:05:45AM +0900, Namhyung Kim escreveu:
> On Thu, Oct 22, 2015 at 11:46 PM, Arnaldo Carvalho de Melo
> > At some point it would be nice to be able to use:
> >
> >         perf top --call-graph caller
> >
> > And have that be equivalent to:
> >
> >         perf top --callgraph fp,graph,0.5,caller,function
> >
> > I.e. change just one of the defaults.
 
> ?? That's supported already by commit e8232f1ad468 ("perf report:
> Relax -g option parsing not to limit the option order")..

Ok, that "point" already happened, good! ;-)
 
> > But I think that how you did it is backwards compatible, i.e. adding
> > stuff just to the end.

> > Ah, noticed you forgot to update the 'top' man page
> 
> Heh, I just added below in the previous patch.. ;-)
> 
> "See `--call-graph` section in perf-record and perf-report man pages
> for details."

Okay then, should be enough :-)
 
> Thanks,
> Namhyung
> 
> /me goes to bed now...

G'nite!