From: Mike Snitzer <snitzer@redhat.com>
To: Ming Lin <mlin@kernel.org>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: block: re-add discard_granularity and alignment checks
Date: Thu, 22 Oct 2015 13:03:10 -0400 [thread overview]
Message-ID: <20151022170310.GA12038@redhat.com> (raw)
In-Reply-To: <1445533182.16385.10.camel@ssi>
On Thu, Oct 22 2015 at 12:59pm -0400,
Ming Lin <mlin@kernel.org> wrote:
> From: Ming Lin <ming.l@ssi.samsung.com>
>
> In commit b49a087("block: remove split code in
> blkdev_issue_{discard,write_same}"), discard_granularity and alignment
> checks were removed. Ideally, with bio late splitting, the upper layers
> shouldn't need to depend on device's limits.
>
> Christoph reported a discard regression on the HGST Ultrastar SN100 NVMe
> device when mkfs.xfs. We have not found the root cause yet.
>
> This patch re-adds discard_granularity and alignment checks by reverting
> the related changes in commit b49a087. The good thing is now we can
> remove the 2G discard size cap and just use UINT_MAX to avoid bi_size
> overflow.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lin <ming.l@ssi.samsung.com>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Thanks!
next prev parent reply other threads:[~2015-10-22 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 16:59 [PATCH] block: re-add discard_granularity and alignment checks Ming Lin
2015-10-22 17:03 ` Mike Snitzer [this message]
2015-10-27 21:23 ` Ming Lin
2015-10-28 0:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022170310.GA12038@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mlin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).