From: Dan Carpenter <dan.carpenter@oracle.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
andreas.dilger@intel.com, gulsah.1004@gmail.com,
gregkh@linuxfoundation.org, shuey@purdue.edu,
oleg.drokin@intel.com, yejiayily@gmail.com,
guillaume.matheron@ens.fr, lustre-devel@lists.lustre.org,
amir.shehata@intel.com, he.huang@intel.com
Subject: Re: [PATCH] staging: lustre: o2iblnd: fix misleading indentation
Date: Thu, 22 Oct 2015 22:48:19 +0300 [thread overview]
Message-ID: <20151022194819.GR7340@mwanda> (raw)
In-Reply-To: <1445449240-30305-1-git-send-email-luisbg@osg.samsung.com>
On Wed, Oct 21, 2015 at 06:40:40PM +0100, Luis de Bethencourt wrote:
> The code is correct, the indentation is misleading. Only the the return rc
> is part of the conditional statement if rc != 0.
>
> Fix a smatch warning:
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157
> kiblnd_hdev_setup_mrs() warn: curly braces intended?
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> This patch gives a warning in checkpatch.pl for the line:
> if (hdev->ibh_mrs == NULL)
>
> It would be cleaner if this was 'if (!hdev->ibh_mrs)' instead. I didn't fix
> this as well because the file has 41 instances of comparisons with NULL. I
> would be happy to do so in a patch in reply to this one if it would be good.
>
You did the right thing. One thing per patch.
regards,
dan carpenter
prev parent reply other threads:[~2015-10-22 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 17:40 [PATCH] staging: lustre: o2iblnd: fix misleading indentation Luis de Bethencourt
2015-10-22 19:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022194819.GR7340@mwanda \
--to=dan.carpenter@oracle.com \
--cc=amir.shehata@intel.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=guillaume.matheron@ens.fr \
--cc=gulsah.1004@gmail.com \
--cc=he.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=shuey@purdue.edu \
--cc=yejiayily@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox