From: Wolfram Sang <wsa@the-dreams.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-i2c@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Anders Berg <anders.berg@avagotech.com>,
Max Schwarz <max.schwarz@online.de>,
David Box <david.e.box@linux.intel.com>,
Wei Yan <sledge.yanwei@huawei.com>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Andrew Bresticker <abrestic@chromium.org>,
linux-kernel@vger.kernel.org, Kamal Dasu <kdasu.kdev@gmail.com>,
Laurentiu Palcu <laurentiu.palcu@intel.com>,
Baruch Siach <baruch@tkos.co.il>,
Xudong Chen <xudong.chen@mediatek.com>,
Lee Jones <lee.jones@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
Sachin Kamat <sachin.kamat@samsung.com>,
Ray Jui <rjui@broadcom.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] i2c: uniphier: add UniPhier FIFO-less I2C driver
Date: Thu, 22 Oct 2015 22:59:09 +0200 [thread overview]
Message-ID: <20151022205908.GA1516@katana> (raw)
In-Reply-To: <1438243942-26401-2-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Thu, Jul 30, 2015 at 05:12:20PM +0900, Masahiro Yamada wrote:
> Add support for on-chip I2C controller used on old UniPhier SoCs
> such as PH1-LD4, PH1-sLD8, etc.. This adapter is so simple that
> it has no FIFO in it.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Finally! Mostly looking good.
> +static u32 uniphier_i2c_functionality(struct i2c_adapter *adap)
> +{
> + return I2C_FUNC_I2C;
> +}
No I2C_FUNC_SMBUS_EMUL? But check if SMBUS_QUICK is supported by your
adapter.
> + regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!regs) {
> + dev_err(dev, "failed to get memory resource");
> + return -EINVAL;
> + }
This 'if'-block can go. devm_ioremap_resource will check it for you.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-22 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 8:12 [PATCH 0/3] i2c: uniphier: add two I2C controller drivers for UniPhier SoC platform Masahiro Yamada
2015-07-30 8:12 ` [PATCH 1/3] i2c: uniphier: add UniPhier FIFO-less I2C driver Masahiro Yamada
2015-10-22 20:59 ` Wolfram Sang [this message]
2015-10-23 10:52 ` Masahiro Yamada
2015-07-30 8:12 ` [PATCH 2/3] i2c: uniphier_f: add UniPhier FIFO-builtin " Masahiro Yamada
2015-10-22 21:06 ` Wolfram Sang
2015-10-23 10:59 ` Masahiro Yamada
2015-07-30 8:12 ` [PATCH 3/3] i2c: uniphier: add bindings for UniPhier I2C controllers Masahiro Yamada
2015-10-22 21:00 ` Wolfram Sang
2015-10-23 10:54 ` Masahiro Yamada
2015-09-25 2:12 ` [PATCH 0/3] i2c: uniphier: add two I2C controller drivers for UniPhier SoC platform Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022205908.GA1516@katana \
--to=wsa@the-dreams.de \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=abrestic@chromium.org \
--cc=anders.berg@avagotech.com \
--cc=baruch@tkos.co.il \
--cc=david.e.box@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=kdasu.kdev@gmail.com \
--cc=laurentiu.palcu@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.schwarz@online.de \
--cc=mika.westerberg@linux.intel.com \
--cc=neelegup@linux.vnet.ibm.com \
--cc=rjui@broadcom.com \
--cc=sachin.kamat@samsung.com \
--cc=sledge.yanwei@huawei.com \
--cc=xudong.chen@mediatek.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox