* [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
@ 2015-10-23 4:30 Nilesh Kokane
2015-10-23 5:00 ` Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Nilesh Kokane @ 2015-10-23 4:30 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger
Cc: gregkh, devel, linux-kernel, suneel.raikar, Nilesh Kokane
Fixed- Return of an errno should typically be negative (ie: return -EAGAIN)
Signed-off-by: Nilesh Kokane <Nilesh.Kokane05@gmail.com>
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/drivers/staging/lustre/lnet/lnet/lib-move.c
index 433faae..10f886f 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-move.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-move.c
@@ -808,7 +808,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
lnet_finalize(ni, msg, -EHOSTUNREACH);
lnet_net_lock(cpt);
- return EHOSTUNREACH;
+ return -EHOSTUNREACH;
}
if (msg->msg_md != NULL &&
@@ -821,7 +821,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
lnet_finalize(ni, msg, -ECANCELED);
lnet_net_lock(cpt);
- return ECANCELED;
+ return -ECANCELED;
}
if (!msg->msg_peertxcredit) {
@@ -838,7 +838,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
if (lp->lp_txcredits < 0) {
msg->msg_tx_delayed = 1;
list_add_tail(&msg->msg_list, &lp->lp_txq);
- return EAGAIN;
+ return -EAGAIN;
}
}
@@ -855,7 +855,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
if (tq->tq_credits < 0) {
msg->msg_tx_delayed = 1;
list_add_tail(&msg->msg_list, &tq->tq_delayed);
- return EAGAIN;
+ return -EAGAIN;
}
}
@@ -922,7 +922,7 @@ lnet_post_routed_recv_locked(lnet_msg_t *msg, int do_recv)
LASSERT(msg->msg_rx_ready_delay);
msg->msg_rx_delayed = 1;
list_add_tail(&msg->msg_list, &lp->lp_rtrq);
- return EAGAIN;
+ return -EAGAIN;
}
}
@@ -942,7 +942,7 @@ lnet_post_routed_recv_locked(lnet_msg_t *msg, int do_recv)
LASSERT(msg->msg_rx_ready_delay);
msg->msg_rx_delayed = 1;
list_add_tail(&msg->msg_list, &rbp->rbp_msgs);
- return EAGAIN;
+ return -EAGAIN;
}
}
@@ -1426,7 +1426,7 @@ lnet_parse_put(lnet_ni_t *ni, lnet_msg_t *msg)
libcfs_id2str(info.mi_id), info.mi_portal,
info.mi_mbits, info.mi_roffset, info.mi_rlength, rc);
- return ENOENT; /* +ve: OK but no match */
+ return -ENOENT; /* +ve: OK but no match */
}
}
@@ -1457,7 +1457,7 @@ lnet_parse_get(lnet_ni_t *ni, lnet_msg_t *msg, int rdma_get)
CNETERR("Dropping GET from %s portal %d match %llu offset %d length %d\n",
libcfs_id2str(info.mi_id), info.mi_portal,
info.mi_mbits, info.mi_roffset, info.mi_rlength);
- return ENOENT; /* +ve: OK but no match */
+ return -ENOENT; /* +ve: OK but no match */
}
LASSERT(rc == LNET_MATCHMD_OK);
@@ -1524,7 +1524,7 @@ lnet_parse_reply(lnet_ni_t *ni, lnet_msg_t *msg)
md->md_me->me_portal);
lnet_res_unlock(cpt);
- return ENOENT; /* +ve: OK but no match */
+ return -ENOENT; /* +ve: OK but no match */
}
LASSERT(md->md_offset == 0);
@@ -1539,7 +1539,7 @@ lnet_parse_reply(lnet_ni_t *ni, lnet_msg_t *msg)
rlength, hdr->msg.reply.dst_wmd.wh_object_cookie,
mlength);
lnet_res_unlock(cpt);
- return ENOENT; /* +ve: OK but no match */
+ return -ENOENT; /* +ve: OK but no match */
}
CDEBUG(D_NET, "%s: Reply from %s of length %d/%d into md %#llx\n",
@@ -1592,7 +1592,7 @@ lnet_parse_ack(lnet_ni_t *ni, lnet_msg_t *msg)
md->md_me->me_portal);
lnet_res_unlock(cpt);
- return ENOENT; /* +ve! */
+ return -ENOENT; /* +ve! */
}
CDEBUG(D_NET, "%s: ACK from %s into md %#llx\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
2015-10-23 4:30 [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Nilesh Kokane
@ 2015-10-23 5:00 ` Dan Carpenter
2015-10-23 6:45 ` Dan Carpenter
2015-10-23 11:40 ` Dilger, Andreas
2015-10-23 15:05 ` Simmons, James A.
2 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2015-10-23 5:00 UTC (permalink / raw)
To: Nilesh Kokane
Cc: oleg.drokin, andreas.dilger, devel, gregkh, linux-kernel,
suneel.raikar
On Fri, Oct 23, 2015 at 10:00:03AM +0530, Nilesh Kokane wrote:
> Fixed- Return of an errno should typically be negative (ie: return -EAGAIN)
>
The changelog needs to describe the use visible effects of this change.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
2015-10-23 5:00 ` Dan Carpenter
@ 2015-10-23 6:45 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-10-23 6:45 UTC (permalink / raw)
To: Nilesh Kokane
Cc: oleg.drokin, andreas.dilger, devel, gregkh, linux-kernel,
suneel.raikar
On Fri, Oct 23, 2015 at 08:00:09AM +0300, Dan Carpenter wrote:
> On Fri, Oct 23, 2015 at 10:00:03AM +0530, Nilesh Kokane wrote:
> > Fixed- Return of an errno should typically be negative (ie: return -EAGAIN)
> >
>
> The changelog needs to describe the use visible effects of this change.
>
I was expecting you to respond to my email saying that you had seen the
mistake... Anyway, bugs like this are why the process requires that
user visible changes need documentation.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
2015-10-23 4:30 [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Nilesh Kokane
2015-10-23 5:00 ` Dan Carpenter
@ 2015-10-23 11:40 ` Dilger, Andreas
2015-10-23 12:09 ` Nilesh Kokane
2015-10-23 15:05 ` Simmons, James A.
2 siblings, 1 reply; 6+ messages in thread
From: Dilger, Andreas @ 2015-10-23 11:40 UTC (permalink / raw)
To: Nilesh Kokane, Drokin, Oleg
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, suneel.raikar@gmail.com
On 2015/10/22, 22:30, "Nilesh Kokane" <nilesh.kokane05@gmail.com> wrote:
>Fixed- Return of an errno should typically be negative (ie: return
>-EAGAIN)
Nak. Please do not change these function return values. They are
converted as necessary by the callers before returning to userspace, but
allow the code to distinguish between errors generated internally or from
lower networking layers.
As you will note, many of them are explicitly annotated with comments that
they are returning positive values. The patch as it stands would totally
break the code.
Cheers, Andreas
>Signed-off-by: Nilesh Kokane <Nilesh.Kokane05@gmail.com>
>---
> drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
>b/drivers/staging/lustre/lnet/lnet/lib-move.c
>index 433faae..10f886f 100644
>--- a/drivers/staging/lustre/lnet/lnet/lib-move.c
>+++ b/drivers/staging/lustre/lnet/lnet/lib-move.c
>@@ -808,7 +808,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
> lnet_finalize(ni, msg, -EHOSTUNREACH);
>
> lnet_net_lock(cpt);
>- return EHOSTUNREACH;
>+ return -EHOSTUNREACH;
> }
>
> if (msg->msg_md != NULL &&
>@@ -821,7 +821,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
> lnet_finalize(ni, msg, -ECANCELED);
>
> lnet_net_lock(cpt);
>- return ECANCELED;
>+ return -ECANCELED;
> }
>
> if (!msg->msg_peertxcredit) {
>@@ -838,7 +838,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
> if (lp->lp_txcredits < 0) {
> msg->msg_tx_delayed = 1;
> list_add_tail(&msg->msg_list, &lp->lp_txq);
>- return EAGAIN;
>+ return -EAGAIN;
> }
> }
>
>@@ -855,7 +855,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
> if (tq->tq_credits < 0) {
> msg->msg_tx_delayed = 1;
> list_add_tail(&msg->msg_list, &tq->tq_delayed);
>- return EAGAIN;
>+ return -EAGAIN;
> }
> }
>
>@@ -922,7 +922,7 @@ lnet_post_routed_recv_locked(lnet_msg_t *msg, int
>do_recv)
> LASSERT(msg->msg_rx_ready_delay);
> msg->msg_rx_delayed = 1;
> list_add_tail(&msg->msg_list, &lp->lp_rtrq);
>- return EAGAIN;
>+ return -EAGAIN;
> }
> }
>
>@@ -942,7 +942,7 @@ lnet_post_routed_recv_locked(lnet_msg_t *msg, int
>do_recv)
> LASSERT(msg->msg_rx_ready_delay);
> msg->msg_rx_delayed = 1;
> list_add_tail(&msg->msg_list, &rbp->rbp_msgs);
>- return EAGAIN;
>+ return -EAGAIN;
> }
> }
>
>@@ -1426,7 +1426,7 @@ lnet_parse_put(lnet_ni_t *ni, lnet_msg_t *msg)
> libcfs_id2str(info.mi_id), info.mi_portal,
> info.mi_mbits, info.mi_roffset, info.mi_rlength, rc);
>
>- return ENOENT; /* +ve: OK but no match */
>+ return -ENOENT; /* +ve: OK but no match */
> }
> }
>
>@@ -1457,7 +1457,7 @@ lnet_parse_get(lnet_ni_t *ni, lnet_msg_t *msg, int
>rdma_get)
> CNETERR("Dropping GET from %s portal %d match %llu offset %d length
>%d\n",
> libcfs_id2str(info.mi_id), info.mi_portal,
> info.mi_mbits, info.mi_roffset, info.mi_rlength);
>- return ENOENT; /* +ve: OK but no match */
>+ return -ENOENT; /* +ve: OK but no match */
> }
>
> LASSERT(rc == LNET_MATCHMD_OK);
>@@ -1524,7 +1524,7 @@ lnet_parse_reply(lnet_ni_t *ni, lnet_msg_t *msg)
> md->md_me->me_portal);
>
> lnet_res_unlock(cpt);
>- return ENOENT; /* +ve: OK but no match */
>+ return -ENOENT; /* +ve: OK but no match */
> }
>
> LASSERT(md->md_offset == 0);
>@@ -1539,7 +1539,7 @@ lnet_parse_reply(lnet_ni_t *ni, lnet_msg_t *msg)
> rlength, hdr->msg.reply.dst_wmd.wh_object_cookie,
> mlength);
> lnet_res_unlock(cpt);
>- return ENOENT; /* +ve: OK but no match */
>+ return -ENOENT; /* +ve: OK but no match */
> }
>
> CDEBUG(D_NET, "%s: Reply from %s of length %d/%d into md %#llx\n",
>@@ -1592,7 +1592,7 @@ lnet_parse_ack(lnet_ni_t *ni, lnet_msg_t *msg)
> md->md_me->me_portal);
>
> lnet_res_unlock(cpt);
>- return ENOENT; /* +ve! */
>+ return -ENOENT; /* +ve! */
> }
>
> CDEBUG(D_NET, "%s: ACK from %s into md %#llx\n",
>--
>1.9.1
>
>
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
2015-10-23 11:40 ` Dilger, Andreas
@ 2015-10-23 12:09 ` Nilesh Kokane
0 siblings, 0 replies; 6+ messages in thread
From: Nilesh Kokane @ 2015-10-23 12:09 UTC (permalink / raw)
To: Dilger, Andreas
Cc: Drokin, Oleg, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
suneel.raikar@gmail.com
On Fri, Oct 23, 2015 at 5:10 PM, Dilger, Andreas
<andreas.dilger@intel.com> wrote:
> On 2015/10/22, 22:30, "Nilesh Kokane" <nilesh.kokane05@gmail.com> wrote:
>>Fixed- Return of an errno should typically be negative (ie: return
>>-EAGAIN)
>
> Nak. Please do not change these function return values. They are
> converted as necessary by the callers before returning to userspace, but
> allow the code to distinguish between errors generated internally or from
> lower networking layers.
>
> As you will note, many of them are explicitly annotated with comments that
> they are returning positive values. The patch as it stands would totally
> break the code.
Ok. I'll take care next time.
--
//Nilesh Kokane
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
2015-10-23 4:30 [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Nilesh Kokane
2015-10-23 5:00 ` Dan Carpenter
2015-10-23 11:40 ` Dilger, Andreas
@ 2015-10-23 15:05 ` Simmons, James A.
2 siblings, 0 replies; 6+ messages in thread
From: Simmons, James A. @ 2015-10-23 15:05 UTC (permalink / raw)
To: 'Nilesh Kokane', oleg.drokin@intel.com,
andreas.dilger@intel.com
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, suneel.raikar@gmail.com
>Fixed- Return of an errno should typically be negative (ie: return -EAGAIN)
>
>Signed-off-by: Nilesh Kokane <Nilesh.Kokane05@gmail.com>
>---
> drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
Bad idea. I also made this mistake and it broke LNet really badly.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-23 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-23 4:30 [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Nilesh Kokane
2015-10-23 5:00 ` Dan Carpenter
2015-10-23 6:45 ` Dan Carpenter
2015-10-23 11:40 ` Dilger, Andreas
2015-10-23 12:09 ` Nilesh Kokane
2015-10-23 15:05 ` Simmons, James A.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).