From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbbJWFsv (ORCPT ); Fri, 23 Oct 2015 01:48:51 -0400 Received: from mail-bn1on0075.outbound.protection.outlook.com ([157.56.110.75]:35648 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752085AbbJWFst (ORCPT ); Fri, 23 Oct 2015 01:48:49 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; topic.nl; dkim=none (message not signed) header.d=none;topic.nl; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Thu, 22 Oct 2015 22:48:42 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Mike Looijmans CC: , , Subject: Re: [PATCH] pinctrl-zynq: Initialize early Message-ID: <20151023054842.GV5257@xsjsorenbubuntu> References: <1445513420-23527-1-git-send-email-mike.looijmans@topic.nl> <20151022160733.GH5257@xsjsorenbubuntu> <5629C62D.8030804@topic.nl> <5629C8F3.2080004@topic.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5629C8F3.2080004@topic.nl> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21894.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC010;1:hGUk2N5qJrQLFJyP3seBGXrfWsvjSaK+lyx38O0HL2w2IOX9u1XxP1yk2Qh207had/o40q3ikS8nXdY8m44oV8ZfAvQq3CI7+2/VUviFASuD2/VX3Vc6zwJYpLe9MXhdECeUHYR5sCv//VuvWNxlHTYOrWIMmr/F6nT+mOjrM7wXoMVNbs3jLimg17Lz0gTeD10c7xm108n0T5C0ttyxLlNQ5OgQQ+P5XsGYsnYJf9GhWokwswrivGruICvVL/rR8/nfaGFVVrRe4cub2Wsq976A7EHjGNSfzu1CRW/OFwRLnUUALY6eG7/yA0Qd4Ji8p6lkiPMrKts17K+7EvLESSpscHLkhP8J6eF7Jn1EHIM= X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(52044002)(24454002)(199003)(76104003)(377424004)(57986006)(50986999)(4001150100001)(81156007)(54356999)(2950100001)(76506005)(11100500001)(63266004)(76176999)(36386004)(6806005)(92566002)(77096005)(33656002)(16796002)(83506001)(5008740100001)(110136002)(93886004)(86362001)(33716001)(5001960100002)(4001350100001)(47776003)(5007970100001)(23676002)(50466002)(189998001)(19580405001)(19580395003)(85202003)(85182001)(106466001)(87936001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB040;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB040;2:yTaZYTNsF3BhABS72d+D5F8zZEnmqUG0MqY8oVh3peNMUydSVr5CaYqyfAvvWeKeXNy1zGJlWOOVcq3i0Z3scZ6j9k/Ttnc4QgW2Xt02vGhW2/f/OEaKkpXjekjYkGGhiQnJdhF3p4ZoksjGVm3XniX67k6NeRq0YTRYO1GYCoc=;3:q4SKKD2mlyjz1lvt83dw0Ws/n9k771niHVh2NO8pNu8iA68U7VZmzizES6Rtmq692iryYRp83enUHaeJfMENRX/dORsuVAf4+VhL0URPwL5gTWJ8Ohx97Z/NLCS5ehTQb47Eo43M+8aB8LZAK4np4PXm53HNJSZUQr2xQORoVdqs8BhZrXwSurlgyRjeVLGgRLEpoXPFtotooFr9d7O9Y1TmuAxpBX5Oor2G65zDAEmD23HMiyfb2J/jhyPhHp1RSMGx2Y9TsRmKIpxGQrqrEw==;25:RdfFq64RoHztGrh91bODRq6ZwKyGN3tne2NiAl/+4mK9h4dT6ILEDB2XPjT581vLJv5gNBzZ1JmXx6VpoObGeFrKob0VRamZjgH1HqQGl72JR6VqFm50jKHSgkMgT2/sgHaZXSBtTJjW9N+Wz4/sgl7uEhhS3dyOAwI21rn9JPF7GQ3bGdh254xScYS3C0b2+v9p3YwQKpqvRpLokkHSyLWWbB2aO1/CjdhuM676Orp/opyD7/Dt26Gi1cjFy6u09MxL82+WPHB9fQX6bDMYUg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BL2FFO11HUB040; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB040;20:VsXNHIfAubaHiyv3NGj9ZJVU6jOuNjFPbhsWsiVGzE6D4nXo/XnTZrlfY8Se5HojjeuSZiaFuTlTWkzP76A6b2xx6jmBZwfu7vyYu+kmFfYspX9oS1986MuvaW+qrU4JwleTqm55zZmGPGsF6/i8Gm85VBZgwkrUQwQKecToRWDJxoRSVdFux20M0J2UwXTDYp5T4w/e5JbAEybzxc2h3INoxHq0SZu36M/wHjNcHTisRTcDjFcWIlcOzRsFGy8bEy7cyZQHALG9jfnuGeOE8MsXLaqbqBlfqGEgNlhLXLaeBkrx1nWszkggVSFHYL385BchoC2cJN6TJ0tIniUkPJkTO6bjijPQwoqE3KRUcB/7U6Ixra/SOg+UcssT8Z2VDtokxZFYTj73V1gcZ1Gc32BxP4xfVm2+KcbXWo7P6n7x0OGoH0J5dRT5qK3sva+x01r8wKXm/Xu19VZ5JkT/8H/EQmk1NX5OW6FGWRXMNENbZJk8sb8DJRGz7z60MsSp;4:TUhay99KJRYVlVk/nGZYeWiFS2AzuviNvYXw5ltFqaCPLwL+Wgf9+C/+XjL7NzYcqvRFZpyWx0cYGeKNKKe/Fsi/hykrByUgZXMKJbMp0Av06Q1f3p/Xh/b213PPDqjg80+SlXwPcWJp1+1A+WDXpH/a7tJsHpLFEoFdzsNeNJPPcrQCPhET/efEGqWlZJo8qLrkxEOm0+nFJtUa5WlAj7Ntsg79wFj2UjPSkpwjdRaZB5ysjfdhMoghuXFd+5E/JZzzHVbmC8i/UJjB518STwY3RAuGDDH78MVK4RM6MgDLZWz2KledCrl77xrU8s2QAfLvNO37Dup4gGvdRuG4OCGSAGpsRHsKD41V6EMvBqIlw0obXUOr2rjssvYMx05CylskV0GIYD9wXw7PlY4bAw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501019)(102215026);SRVR:BL2FFO11HUB040;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB040; X-Forefront-PRVS: 0738AF4208 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJGRk8xMUhVQjA0MDsyMzppVHg2K0lxSkpJQUQybm1Ob3I3czJEeTdL?= =?utf-8?B?VVNMTWwyMjNhakZDUk96Wjhzblc2cGhsYTFWTEJrN2dJdFAyRWhWK0puYW10?= =?utf-8?B?ZnhkSXZuck1ydXVpNjlINnIrbWJJRHQvcmErYmpmRTRBTlM0VlRUYWNrWG1l?= =?utf-8?B?T1NNYUVTa2dKNHVCaTF4TUJwelljZXhuTllQQ1FVTitmSm9UcnhVRnYyWVdV?= =?utf-8?B?Ym5IVERKZE4zYkpEM0RsbEo4OCtPSU5rUEZLWEozcXlqZi9WUDg1akJ4RlNR?= =?utf-8?B?cjFtWkdLWmtJR3dMZFNGNjZuL1RvZFJPZWsrVUZNaVdZNkNWd3NJVXpOMERm?= =?utf-8?B?WlJMWWVGc3dGN2tKMjJWd2NEMUNHdGFXblBtdUo2dlphbnptaGVMMFd3UEpx?= =?utf-8?B?dWdTNlZqVlZiRC81U0dDd1ZkWk9oUUppek5PVjN6VE4wd0Q5eGpDODdobHRQ?= =?utf-8?B?S0tYRjQxb1pFQ21QMi9oVitXZTRtbmZhRm9TYVJ0dWFHbWkvSFVCb2wwTFp0?= =?utf-8?B?Y1FwdVJYbnVDRmdFejhqZ3hlNUlEVjQ4SXVhZTYrZzNRTnJLbXU4bDAzSStz?= =?utf-8?B?TXJDb1MxM0lCczM5ejJFeHlVbDZVZVlzTjh6U0FqdmxMWWF2aTZReUVaOUdK?= =?utf-8?B?Y2N3TUZzdUJibWwxVmVEUCttNTB3cmlVYXJReHRCK0k0RDZ1aHNHZllVSHhY?= =?utf-8?B?aUJzZldMRkdtSDY5NXdzZ2ZrNnZzbDU5N0laUk1MWXhNNlQzSzEwcW95S0xs?= =?utf-8?B?SzJDRHhzZWVzQ2lUUUQ3K0NmcWQvRGxUb2ErcUc5WHYxMFFBYm1Hdm1XTUdT?= =?utf-8?B?TjY2Z21VTXRuT3k5NlBhZmNPMHEvOEhyVXM2Z2lJQ0lzMzMxQjB3OVJuTzRy?= =?utf-8?B?amhiTXJYM1c2SUo1bExVQXUvYUZFMFZ2YmVIeFljQko2MFhVTHk5MEdLcVQr?= =?utf-8?B?NEpGbWNrRU5OMjUzSUpZbmQyWjdtc2lXUnZXTWRTbmZmVktzOHlKYVV2K3RX?= =?utf-8?B?WDkvUkJ5VmhrelJNYWs3WDhObzZiTWRGTEQvZXN0LzZnRXJFZDhLelFJa1A0?= =?utf-8?B?WWtsRXBHdExhYVo3dWIwRG9rVi9uWEJOOTlpWGRyVm44S1RLdXlrcGdWRDZG?= =?utf-8?B?eVlKWkxUMm82elBjb0lHdWZkejN6SkZDOURQcStZVmFwVjBkMGVTK1dJN1Ax?= =?utf-8?B?M0ZjbUI3M2xXRkh2TEs3R1dZQ1YwUDdsWXp2NkFpZm5RV2t6U2xML1VRR01E?= =?utf-8?B?dlRwamd6VHdENTRsVVJnNGw1U2dSK1VGUnZkc3YyZ3RybmNKOCtySGxuZ3NI?= =?utf-8?B?dzlibDQrN0x5MFBDcXQ4amp0SDNNYTd5YzBxL0FxY1RiTkh1dzRMS0kvWGJL?= =?utf-8?B?aFVUakJrRVBhNW5RV1lsVHpCb081UWZSdXVtSHFrbTlEQytqLzUzS1RjaHlE?= =?utf-8?B?MGZBb1NBTGlSMUFZU0NMMCtlckN3RmJoUVVscEhncEdmdGNVd1VpN29HcUV2?= =?utf-8?B?UE55ZHhyN1N2Q256aDU3RlBwZGhPVk12NGhqeGdvQXVxNkp0ZXY3M2NUNEpo?= =?utf-8?B?SHAzMjdCTTdYMDRqdUdrcG1MZ0NMcVkrVEMxeUxKYnVBTHova24rblhielpn?= =?utf-8?Q?H8Y6oJ4mS8NZmYsrkmSnI?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB040;5:pUPwSmL/X0SxP+7WcKYovOmt2RCmbCLDhhBS5Zkr9ZUuHJ53YwJ+EGnDGWWpAesfzWffUq+iWIUsLlP76WZM4liBGyRi73JJMJuXz5s09xSBIBqyxe0XczSRXK+TrVG3s5g0gRtzgcrbj7mzNeI7ww==;24:B0neq7zsC/WWE2PU+ijvpe4OJ6FAeAZkrCe1znUp5QGIzXfP2AV3xC6kEWXsnCwlUN7dDlYoYnlP/9E1kXo9gjSsBeSi6W4uankxhy0Eb1Y= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2015 05:48:47.3761 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB040 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-23 at 07:43AM +0200, Mike Looijmans wrote: > On 23-10-15 07:31, Mike Looijmans wrote: > >On 22-10-15 18:07, Sören Brinkmann wrote: > >>Hi Mike, > >> > >>On Thu, 2015-10-22 at 01:30PM +0200, Mike Looijmans wrote: > >>>Supplying pinmux configuration for e.g. gpio pins leads to deferred > >>>probes because the pinctrl device is probed much later than gpio. > >>>Move the init call to a much earlier stage so it probes before the > >>>devices that may need it. > >>> > >>>Signed-off-by: Mike Looijmans > >> > >>in general, the change should be OK, but neither on zc702 nor zc706 do I > >>see a difference in respect to deferred probes. With and without the > >>patch I see: > >> root@zynq:~# dmesg | grep -i defer > >> [ 0.097021] zynq-gpio e000a000.gpio: could not find pctldev for node > >>/amba/slcr@f8000000/pinctrl@700/gpio0-default, deferring probe > >> root@zynq:~# > >> > >>If you have a case this patch improves things though, feel free to add my > >>Tested-by: Sören Brinkmann > >> > > > >On the Florida boards there are i2c controlled clocks, power supplies and > >reset signals. Replacing the Cadence I2C controller with a GPIO-bitbang > >controller solved the I2C problems but caused a storm of dozens of deferred > >probes because of the pinmux driver arriving even after the first probe > >attempt of the i2c bus driver. Moving the pinmux driver to an earlier stage > >solved that problem neatly, now the "zynq-pinctrl 700.pinctrl: zynq pinctrl > >initialized" message appears after the OCM driver. > >Judging from your comment the GPIO driver still probes earlier (I don't have > >any GPIO-only pinmuxes yet), so maybe we should amend the patch to probe even > >earlier. The pinmux driver doesn't depend on anything, so it can potentially > >probe very early. What do you think? > > Minor addition: > The gpio-zynq driver probes at "postcore_initcall", so to beat that, the > zynq-pinmux driver should move to "core_initcall" (instead of > "arch_initcall"). That would make the gpio deferral go away. > > An alternative would be to move the gpio driver to "arch", then "postcore" > would be enough for the pinmux. If the gpio probe gets deferred, it > apparently has already been moved to below "subsys" already, with aparently > no ill effects. Makes me wonder whether a single deferred probe is worth the risk of breaking something by moving these things around. But probably worth a try. Sören