From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nilesh Kokane <nilesh.kokane05@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, suneel.raikar@gmail.com
Subject: Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
Date: Fri, 23 Oct 2015 09:45:58 +0300 [thread overview]
Message-ID: <20151023064558.GZ7289@mwanda> (raw)
In-Reply-To: <20151023050009.GU7340@mwanda>
On Fri, Oct 23, 2015 at 08:00:09AM +0300, Dan Carpenter wrote:
> On Fri, Oct 23, 2015 at 10:00:03AM +0530, Nilesh Kokane wrote:
> > Fixed- Return of an errno should typically be negative (ie: return -EAGAIN)
> >
>
> The changelog needs to describe the use visible effects of this change.
>
I was expecting you to respond to my email saying that you had seen the
mistake... Anyway, bugs like this are why the process requires that
user visible changes need documentation.
regards,
dan carpenter
next prev parent reply other threads:[~2015-10-23 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 4:30 [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Nilesh Kokane
2015-10-23 5:00 ` Dan Carpenter
2015-10-23 6:45 ` Dan Carpenter [this message]
2015-10-23 11:40 ` Dilger, Andreas
2015-10-23 12:09 ` Nilesh Kokane
2015-10-23 15:05 ` Simmons, James A.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023064558.GZ7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nilesh.kokane05@gmail.com \
--cc=oleg.drokin@intel.com \
--cc=suneel.raikar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).