From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbbJWGqP (ORCPT ); Fri, 23 Oct 2015 02:46:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25781 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbbJWGqO (ORCPT ); Fri, 23 Oct 2015 02:46:14 -0400 Date: Fri, 23 Oct 2015 09:45:58 +0300 From: Dan Carpenter To: Nilesh Kokane Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, suneel.raikar@gmail.com Subject: Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Message-ID: <20151023064558.GZ7289@mwanda> References: <1445574603-4023-1-git-send-email-Nilesh.Kokane05@gmail.com> <20151023050009.GU7340@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151023050009.GU7340@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2015 at 08:00:09AM +0300, Dan Carpenter wrote: > On Fri, Oct 23, 2015 at 10:00:03AM +0530, Nilesh Kokane wrote: > > Fixed- Return of an errno should typically be negative (ie: return -EAGAIN) > > > > The changelog needs to describe the use visible effects of this change. > I was expecting you to respond to my email saying that you had seen the mistake... Anyway, bugs like this are why the process requires that user visible changes need documentation. regards, dan carpenter