Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t

kbuild test robot
2015-10-23T12:44:47Z

[-- Attachment #1: Type: text/plain, Size: 3399 bytes --]

Hi LABBE,

[auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url: https://github.com/0day-ci/linux/commits/LABBE-Corentin/net-change-len-parameter-type-for-memcpy_-to-from-_msg/20151023-201642
config: xtensa-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa

All warnings (new ones prefixed by >>):

In file included from include/asm-generic/bug.h:13:0,
from arch/xtensa/include/generated/asm/bug.h:1,
from include/linux/bug.h:4,
from include/linux/thread_info.h:11,
from arch/xtensa/include/asm/current.h:16,
from net/ipv4/raw.c:43:
net/ipv4/raw.c: In function 'raw_getfrag':
include/linux/kernel.h:722:17: warning: comparison of distinct pointer types lacks a cast
(void) (&_min1 == &_min2); \
^
>> net/ipv4/raw.c:458:14: note: in expansion of macro 'min'
int copy = min(rfv->hlen - offset, len);
^

vim +/min +458 net/ipv4/raw.c

b61e9dcc5 Al Viro 2014-11-24 442 err = memcpy_from_msg(rfv->hdr.c, rfv->msg, rfv->hlen);
32b5913a9 Herbert Xu 2014-11-07 443 if (err)
32b5913a9 Herbert Xu 2014-11-07 444 return err;
^1da177e4 Linus Torvalds 2005-04-16 445
c008ba5bd Herbert Xu 2014-11-07 446 fl4->fl4_icmp_type = rfv->hdr.icmph.type;
c008ba5bd Herbert Xu 2014-11-07 447 fl4->fl4_icmp_code = rfv->hdr.icmph.code;
^1da177e4 Linus Torvalds 2005-04-16 448
a27b58fed Heiko Carstens 2006-10-30 449 return 0;
^1da177e4 Linus Torvalds 2005-04-16 450 }
^1da177e4 Linus Torvalds 2005-04-16 451
c008ba5bd Herbert Xu 2014-11-07 452 static int raw_getfrag(void *from, char *to, int offset, int len, int odd,
c008ba5bd Herbert Xu 2014-11-07 453 struct sk_buff *skb)
c008ba5bd Herbert Xu 2014-11-07 454 {
c008ba5bd Herbert Xu 2014-11-07 455 struct raw_frag_vec *rfv = from;
c008ba5bd Herbert Xu 2014-11-07 456
c008ba5bd Herbert Xu 2014-11-07 457 if (offset < rfv->hlen) {
c008ba5bd Herbert Xu 2014-11-07 @458 int copy = min(rfv->hlen - offset, len);
c008ba5bd Herbert Xu 2014-11-07 459
c008ba5bd Herbert Xu 2014-11-07 460 if (skb->ip_summed == CHECKSUM_PARTIAL)
c008ba5bd Herbert Xu 2014-11-07 461 memcpy(to, rfv->hdr.c + offset, copy);
c008ba5bd Herbert Xu 2014-11-07 462 else
c008ba5bd Herbert Xu 2014-11-07 463 skb->csum = csum_block_add(
c008ba5bd Herbert Xu 2014-11-07 464 skb->csum,
c008ba5bd Herbert Xu 2014-11-07 465 csum_partial_copy_nocheck(rfv->hdr.c + offset,
c008ba5bd Herbert Xu 2014-11-07 466 to, copy, 0),

:::::: The code at line 458 was first introduced by commit
:::::: c008ba5bdc9fa830e1a349b20b0be5a137bdef7a ipv4: Avoid reading user iov twice after raw_probe_proto_opt

:::::: TO: Herbert Xu <herbert@gondor.apana.org.au>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 42431 bytes --]