From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbbJWNfJ (ORCPT ); Fri, 23 Oct 2015 09:35:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57615 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbbJWNfH (ORCPT ); Fri, 23 Oct 2015 09:35:07 -0400 Date: Fri, 23 Oct 2015 16:35:02 +0300 From: "Michael S. Tsirkin" To: LABBE Corentin Cc: al.drozdov@gmail.com, daniel@iogearbox.net, davem@davemloft.net, dwmw2@infradead.org, edumazet@google.com, eyal.birger@gmail.com, viro@zeniv.linux.org.uk, willemb@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 04/11] net: packet: change vnet_hdr_len from int to size_t Message-ID: <20151023163441-mutt-send-email-mst@redhat.com> References: <1445602236-24130-1-git-send-email-clabbe.montjoie@gmail.com> <1445602236-24130-5-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445602236-24130-5-git-send-email-clabbe.montjoie@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2015 at 02:10:29PM +0200, LABBE Corentin wrote: > vnet_hdr_len cannot be negative and is use in operation/function that > wait for unsigned value. > This patch set vnet_hdr_len as size_t. > > Signed-off-by: LABBE Corentin These things need to be done carefully. I'll look at this next week. > --- > net/packet/af_packet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > index aa4b15c..58a5c8f 100644 > --- a/net/packet/af_packet.c > +++ b/net/packet/af_packet.c > @@ -2632,7 +2632,7 @@ static int packet_snd(struct socket *sock, struct msghdr *msg, size_t len) > int err, reserve = 0; > struct virtio_net_hdr vnet_hdr = { 0 }; > int offset = 0; > - int vnet_hdr_len; > + size_t vnet_hdr_len; > struct packet_sock *po = pkt_sk(sk); > unsigned short gso_type = 0; > int hlen, tlen; > @@ -3106,7 +3106,7 @@ static int packet_recvmsg(struct socket *sock, struct msghdr *msg, size_t len, > struct sock *sk = sock->sk; > struct sk_buff *skb; > int copied, err; > - int vnet_hdr_len = 0; > + size_t vnet_hdr_len = 0; > unsigned int origlen = 0; > > err = -EINVAL; > -- > 2.4.10