From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753171AbbJYI3w (ORCPT ); Sun, 25 Oct 2015 04:29:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33720 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752318AbbJYI3r (ORCPT ); Sun, 25 Oct 2015 04:29:47 -0400 Date: Sat, 24 Oct 2015 19:05:32 -0700 From: Greg Kroah-Hartman To: Geliang Tang Cc: devel@driverdev.osuosl.org, Mike Marciniszyn , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Ledford , Sean Hefty , Hal Rosenstock Subject: Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header Message-ID: <20151025020532.GA22888@kroah.com> References: <7653f784da256d3424c84d2c743d660219d66499.1445175749.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7653f784da256d3424c84d2c743d660219d66499.1445175749.git.geliangtang@163.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote: > sched.h header in ipath_*.c is now unnecessary, since I have added > sched.h in ipath_kernel.h. So remove it. Overall, it's best to split this type of thing out, don't "hide" .h includes in another .h file, so I'm not going to take this patch, sorry. thanks, greg k-h