From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbbJYIh1 (ORCPT ); Sun, 25 Oct 2015 04:37:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34025 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbbJYIhD (ORCPT ); Sun, 25 Oct 2015 04:37:03 -0400 Date: Sat, 24 Oct 2015 19:52:33 -0700 From: Greg KH To: dave penkler Cc: peter.chen@freescale.com, teuniz@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec Message-ID: <20151025025233.GB25874@kroah.com> References: <20151019073320.GA5541@slacky> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151019073320.GA5541@slacky> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2015 at 09:33:20AM +0200, dave penkler wrote: > > Implement support for the USB488 defined READ_STATUS_BYTE and SRQ > notifications with ioctl, fasync and poll/select in order to be able > to synchronize with variable duration instrument operations. > > Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and > LOCAL_LOCKOUT. > > Add convenience ioctl to return all device capabilities. Can you break this up into a series of patches, all doing only one thing? You are doing a lot of different things in this single patch, making it almost impossible to review :( thanks, greg k-h