From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752670AbbJYIqP (ORCPT <rfc822;w@1wt.eu>);
	Sun, 25 Oct 2015 04:46:15 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:35528 "EHLO
	mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751077AbbJYIqM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 25 Oct 2015 04:46:12 -0400
Date: Sun, 25 Oct 2015 09:46:07 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>,
        Borislav Petkov <bp@suse.de>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Chandler Carruth <chandlerc@gmail.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 0/2] perf/core new features
Message-ID: <20151025084607.GA24337@gmail.com>
References: <1445648242-3231-1-git-send-email-acme@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445648242-3231-1-git-send-email-acme@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 80fcd45ee05b4ef05e61d37a5ffb70a67095a9f6:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-23 10:25:57 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 161d9041782b86c5493481566539bfc058ceeaff:
> 
>   perf tools: Provide help for subset of options (2015-10-23 21:50:50 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements:
> 
> New features:
> 
> - Show ordered command line options when -h is used or when an
>   unknown option is specified (Arnaldo Carvalho de Melo)
> 
> - If options are passed after -h, show just its descriptions, not
>   all options (Arnaldo Carvalho de Melo)

Very nice!

> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
>       perf tools: Show tool command line options ordered
>       perf tools: Provide help for subset of options
> 
>  tools/perf/util/parse-options.c | 90 ++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 81 insertions(+), 9 deletions(-)

Pulled, thanks a lot Arnaldo!

So I tested this a bit, and the ordering works well.

What wasn't so obvious to me was behavior like:

  triton:~/tip> perf report -h x

   Usage: perf report [<options>]


  triton:~/tip> 

  triton:~/tip> perf report -h exclude-other

   Usage: perf report [<options>]


  triton:~/tip> 

I.e. it outputs nothing and does not tell the user what's wrong.

Then I figured out the right syntax:

  triton:~/tip> perf report -h --exclude-other

   Usage: perf report [<options>]

      -x, --exclude-other   Only display entries with parent-match

  triton:~/tip> 

:)

So maybe we should also try a search for the option name with a '-' and '--' 
prepended? Also, my pet peeve are partial matches:

  triton:~/tip> perf report -h --exclude

   Usage: perf report [<options>]


  triton:~/tip> 

But in any case it's a nice step forward!

	Ingo