From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbbJYIsk (ORCPT ); Sun, 25 Oct 2015 04:48:40 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36964 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbbJYIsj (ORCPT ); Sun, 25 Oct 2015 04:48:39 -0400 Date: Sun, 25 Oct 2015 09:48:35 +0100 From: Ingo Molnar To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 1/4] perf tools: Improve ambiguous option help message Message-ID: <20151025084834.GB24337@gmail.com> References: <1445701767-12731-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445701767-12731-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Namhyung Kim wrote: > Currently if an option name is ambiguous it only prints first two > matched option names but no help. It'd be better it could show all > possible names and help messages too. > > Before: > $ perf report --show > Error: Ambiguous option: show (could be --show-total-period or > --show-ref-call-graph) > Usage: perf report [] > > After: > $ perf report --show > Error: Ambiguous option: show (could be --show-total-period or > --show-ref-call-graph) > Usage: perf report [] > > -n, --show-nr-samples > Show a column with the number of samples > --showcpuutilization > Show sample percentage for different cpu modes > -I, --show-info Display extended information about perf.data file > --show-total-period > Show a column with the sum of periods > --show-ref-call-graph > Show callgraph from reference event Very nice touch! Acked-by: Ingo Molnar Thanks, Ingo