From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 3/4] perf tools: Setup pager when printing usage and help
Date: Sun, 25 Oct 2015 10:04:23 +0100 [thread overview]
Message-ID: <20151025090423.GD24337@gmail.com> (raw)
In-Reply-To: <1445701767-12731-3-git-send-email-namhyung@kernel.org>
* Namhyung Kim <namhyung@kernel.org> wrote:
> It's annoying to see error or help message when command has many options like in
> perf record, report or top. [...]
That's indeed so.
> [...] So setup pager when print parser error or help message - it should be OK
> since no UI is enabled at the parsing time. The usage_with_options() already
> disables it by calling exit_browser() anyway.
So I wanted to write that this has a disadvantage as well, that the pager disrupts
the regular 'timeline', 'append-only' visual flow of a regular shell workflow.
But then I tried your patches, and for short outputs (such as 'perf stat -h') the
pager is not activated, while for longer output (such as 'perf report -h') it's
activated.
That's very intuitive:
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2015-10-25 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 15:49 [PATCH 1/4] perf tools: Improve ambiguous option help message Namhyung Kim
2015-10-24 15:49 ` [PATCH 2/4] perf report: Rename to --show-cpu-utilization Namhyung Kim
2015-10-25 8:59 ` Ingo Molnar
2015-10-29 9:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-24 15:49 ` [PATCH 3/4] perf tools: Setup pager when printing usage and help Namhyung Kim
2015-10-25 9:04 ` Ingo Molnar [this message]
2015-10-29 9:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-24 15:49 ` [PATCH 4/4] perf tools: Introduce usage_with_options_msg() Namhyung Kim
2015-10-26 17:13 ` Arnaldo Carvalho de Melo
2015-10-26 23:13 ` 平松雅巳 / HIRAMATU，MASAMI
2015-10-27 12:29 ` Arnaldo Carvalho de Melo
2015-10-29 9:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-25 8:48 ` [PATCH 1/4] perf tools: Improve ambiguous option help message Ingo Molnar
2015-10-29 9:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151025090423.GD24337@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).