From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbbJYJE3 (ORCPT ); Sun, 25 Oct 2015 05:04:29 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:34682 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbbJYJE1 (ORCPT ); Sun, 25 Oct 2015 05:04:27 -0400 Date: Sun, 25 Oct 2015 10:04:23 +0100 From: Ingo Molnar To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 3/4] perf tools: Setup pager when printing usage and help Message-ID: <20151025090423.GD24337@gmail.com> References: <1445701767-12731-1-git-send-email-namhyung@kernel.org> <1445701767-12731-3-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445701767-12731-3-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Namhyung Kim wrote: > It's annoying to see error or help message when command has many options like in > perf record, report or top. [...] That's indeed so. > [...] So setup pager when print parser error or help message - it should be OK > since no UI is enabled at the parsing time. The usage_with_options() already > disables it by calling exit_browser() anyway. So I wanted to write that this has a disadvantage as well, that the pager disrupts the regular 'timeline', 'append-only' visual flow of a regular shell workflow. But then I tried your patches, and for short outputs (such as 'perf stat -h') the pager is not activated, while for longer output (such as 'perf report -h') it's activated. That's very intuitive: Acked-by: Ingo Molnar Thanks, Ingo