From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751573AbbJYKAY (ORCPT ); Sun, 25 Oct 2015 06:00:24 -0400 Received: from eso.teric.us ([69.164.192.171]:36558 "EHLO eso.teric.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbbJYKAX (ORCPT ); Sun, 25 Oct 2015 06:00:23 -0400 Date: Sun, 25 Oct 2015 05:00:21 -0500 From: Josh Cartwright To: atull Cc: Moritz Fischer , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [RFC] fpga: socfpga: Fix check of return value of devm_request_irq Message-ID: <20151025100021.GF1279@kryptos> References: <1445541167-7095-1-git-send-email-moritz.fischer@ettus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 22, 2015 at 02:24:03PM -0500, atull wrote: > > The return value should be checked for non-zero, instead > > of checking it being IS_ERR_VALUE(). > >=20 > > Signed-off-by: Moritz Fischer > On Thu, 22 Oct 2015, Moritz Fischer wrote: >=20 > Hi Moritz, >=20 > Thank you, yes this is better. >=20 > I don't know if I need to ack everything, but here it is > anyway: >=20 > Acked-by: Alan Tull Because Greg is the one picking up patches for the FPGA manager stuff right now, you'll want to make sure he's at least CC'd. A proper resend would likely be the easiest way for him to pick it up. Feel free to add by Reviewed-by as well: Reviewed-by: Josh Cartwright Thanks, Josh > > --- > > drivers/fpga/socfpga.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c > > index 706b80d..27d2ff2 100644 > > --- a/drivers/fpga/socfpga.c > > +++ b/drivers/fpga/socfpga.c > > @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_devic= e *pdev) > > =20 > > ret =3D devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0, > > dev_name(dev), priv); > > - if (IS_ERR_VALUE(ret)) > > + if (ret) > > return ret; > > =20 > > return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager", > > --=20 > > 2.4.3 > >=20 > >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJWLKgxAAoJEFQ/W/ipfAAciq4IAIvJv96nwP19JSBRjguO2ULr wq+y/BxCyxh5AEgpS5OWinW3k9R1GFrS2im1sxHW56VP0Vv5TDsvS6xegqXK9llH q64srN5Ond3+LYZS4iQB1UVM7GqAqqIbMquPtWNwk4KNfvZwbHzcIY+Xgz4S2DXX W6bcmPOv9BIvlfGvlQHDcU4IRODeLXGJa0ONmNzslTLIKexwASm6aWAK5+j8rs0i +fOE475wc7k3yAcByuUbelMCexKdMW8DlcCjdUPFu3ChTpAw8GgI/d3gYy0dU0TT XrXBVa+JkuKGgcYHsFpZ4vatoeXLd+ch1WguS2A71tCJk88JgECdKxRVdNs94gQ= =ugiQ -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--