From: Oleg Nesterov <oleg@redhat.com>
To: Tycho Andersen <tycho.andersen@canonical.com>
Cc: Kees Cook <keescook@chromium.org>,
Alexei Starovoitov <ast@kernel.org>,
Will Drewry <wad@chromium.org>,
Andy Lutomirski <luto@amacapital.net>,
Pavel Emelyanov <xemul@parallels.com>,
"Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
Daniel Borkmann <daniel@iogearbox.net>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v8] seccomp, ptrace: add support for dumping seccomp filters
Date: Sun, 25 Oct 2015 16:39:43 +0100 [thread overview]
Message-ID: <20151025153943.GA1912@redhat.com> (raw)
In-Reply-To: <20151021213306.GF30729@hopstrocity>
On 10/21, Tycho Andersen wrote:
>
> > And this leads to another question... If we expect that this interface
> > can change later, then perhaps PTRACE_SECCOMP_GET_FILTER should also
> > dump some header before copy_to_user(fprog->filter) ? Say, just
> > "unsigned long version" == 0 for now. So that we can avoid
> > PTRACE_SECCOMP_GET_FILTER_V2 in future.
>
> So this is interesting. Like Kees mentioned, the bulk of the work
> would be done by the bpf syscall. We'd still need some way to get
> access to the fd itself, which we could (ab)use
> PTRACE_SECCOMP_GET_FILTER for, by returning the fd + BPF_MAXINSNS (so
> that it doesn't conflict with length) or something like that. Or add a
> _V2 as you say. If there is some change we can make to have a nicer
> interface than fd + BPF_MAXINSNS to future proof, I'm fine with making
> it.
Can't comment, this is up to you/Kees ;)
So, just in case, let me repeat I am fine with this patch.
Oleg.
next prev parent reply other threads:[~2015-10-25 14:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 19:50 v8 of seccomp filter c/r Tycho Andersen
2015-10-20 19:50 ` [PATCH v8] seccomp, ptrace: add support for dumping seccomp filters Tycho Andersen
2015-10-20 20:20 ` Oleg Nesterov
2015-10-20 20:26 ` Kees Cook
2015-10-20 20:37 ` Tycho Andersen
2015-10-20 22:08 ` Tycho Andersen
2015-10-21 18:51 ` Oleg Nesterov
2015-10-21 19:15 ` Tycho Andersen
2015-10-21 20:12 ` Kees Cook
2015-10-21 20:18 ` Daniel Borkmann
2015-10-21 20:37 ` Tycho Andersen
2015-10-21 21:07 ` Oleg Nesterov
2015-10-21 21:20 ` Kees Cook
2015-10-21 21:33 ` Tycho Andersen
2015-10-25 15:39 ` Oleg Nesterov [this message]
2015-10-26 6:46 ` Kees Cook
2015-10-26 7:07 ` Kees Cook
2015-10-27 0:04 ` Tycho Andersen
2015-10-27 0:17 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151025153943.GA1912@redhat.com \
--to=oleg@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=serge.hallyn@ubuntu.com \
--cc=tycho.andersen@canonical.com \
--cc=wad@chromium.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).