From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbbJYTg5 (ORCPT ); Sun, 25 Oct 2015 15:36:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:54176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbbJYTgz (ORCPT ); Sun, 25 Oct 2015 15:36:55 -0400 Date: Sun, 25 Oct 2015 16:36:50 -0300 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Borislav Petkov , Brendan Gregg , Chandler Carruth , David Ahern , Frederic Weisbecker , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Stephane Eranian , Wang Nan Subject: Re: [GIT PULL 0/2] perf/core new features Message-ID: <20151025193650.GK27006@kernel.org> References: <1445648242-3231-1-git-send-email-acme@kernel.org> <20151025084607.GA24337@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151025084607.GA24337@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Oct 25, 2015 at 09:46:07AM +0100, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo wrote: > > > Hi Ingo, > > > > Please consider pulling, > > > > - Arnaldo > > > > The following changes since commit 80fcd45ee05b4ef05e61d37a5ffb70a67095a9f6: > > > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-23 10:25:57 +0200) > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo > > > > for you to fetch changes up to 161d9041782b86c5493481566539bfc058ceeaff: > > > > perf tools: Provide help for subset of options (2015-10-23 21:50:50 -0300) > > > > ---------------------------------------------------------------- > > perf/core improvements: > > > > New features: > > > > - Show ordered command line options when -h is used or when an > > unknown option is specified (Arnaldo Carvalho de Melo) > > > > - If options are passed after -h, show just its descriptions, not > > all options (Arnaldo Carvalho de Melo) > > Very nice! > > > Signed-off-by: Arnaldo Carvalho de Melo > > > > ---------------------------------------------------------------- > > Arnaldo Carvalho de Melo (2): > > perf tools: Show tool command line options ordered > > perf tools: Provide help for subset of options > > > > tools/perf/util/parse-options.c | 90 ++++++++++++++++++++++++++++++++++++----- > > 1 file changed, 81 insertions(+), 9 deletions(-) > > Pulled, thanks a lot Arnaldo! > > So I tested this a bit, and the ordering works well. > > What wasn't so obvious to me was behavior like: > > triton:~/tip> perf report -h x > > Usage: perf report [] I'll fix that, and also make it search the provided key as a substring in the event descriptions, like 'perf list' does now, does that sound ok? - Arnaldo > > triton:~/tip> > > triton:~/tip> perf report -h exclude-other > > Usage: perf report [] > > > triton:~/tip> > > I.e. it outputs nothing and does not tell the user what's wrong. > > Then I figured out the right syntax: > > triton:~/tip> perf report -h --exclude-other > > Usage: perf report [] > > -x, --exclude-other Only display entries with parent-match > > triton:~/tip> > > :) > > So maybe we should also try a search for the option name with a '-' and '--' > prepended? Also, my pet peeve are partial matches: > > triton:~/tip> perf report -h --exclude > > Usage: perf report [] > > > triton:~/tip> > > But in any case it's a nice step forward! > > Ingo